✨ S4L Lite: 11.08 meeting feedback (⚠️ devops)

[odeimaiz]

What do these changes do?

• Rename product: s4llight -> s4llite
• Login Page
  • Shorter hash
  • Company name
  • New splitimage
  • License section in Cookie Policy dialog
• Feedback via email
• Forum link

Devops: rename product name (I'll take care of it)

Related issue/s

related to ITISFoundation/osparc-issues#740
related to ITISFoundation/osparc-issues#765

How to test

Checklist

[codecov]

Codecov Report

Merging #3534 (5bcbd86) into master (767860c) will increase coverage by 4.7%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #3534      +/-   ##
=========================================
+ Coverage    76.9%   81.7%    +4.7%     
=========================================
  Files         852     351     -501     
  Lines       35991   18005   -17986     
  Branches      757     133     -624     
=========================================
- Hits        27705   14717   -12988     
+ Misses       8089    3239    -4850     
+ Partials      197      49     -148     

Flag	Coverage Δ
integrationtests	52.2% <100.0%> (-13.4%)	⬇️
unittests	82.3% <100.0%> (+6.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...eb/server/src/simcore_service_webserver/statics.py	62.5% <ø> (ø)
...er/src/simcore_service_webserver/statics_events.py	39.2% <ø> (ø)
...src/simcore_service_webserver/statics_constants.py	100.0% <100.0%> (ø)
...-v2/src/simcore_service_director_v2/cli/_client.py	0.0% <0.0%> (-100.0%)	⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py	0.0% <0.0%> (-100.0%)	⬇️
...service_director_v2/cli/_close_and_save_service.py	0.0% <0.0%> (-100.0%)	⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py	0.0% <0.0%> (-87.5%)	⬇️
...ce_director_v2/modules/db/repositories/clusters.py	23.0% <0.0%> (-71.7%)	⬇️
...ervice_director_v2/api/routes/dynamic_scheduler.py	38.2% <0.0%> (-57.4%)	⬇️
...k/src/simcore_sdk/node_ports_v2/port_validation.py	47.9% <0.0%> (-48.0%)	⬇️
... and 650 more

[pcrespov]

• This image services/static-webserver/client/source/resource/osparc/s4llite_splitimage.png is over 1MB limit per file in our repo.
  The pre-commit hooks should have stop this commit. Does it work in your computer? See

  osparc-simcore/.pre-commit-config.yaml

  Line 10 in 9dfda53

  args: ["--maxkb=1024"]

Is there any chance to move these images to another repo and use links to them?

[pcrespov]

Do not forget to add (⚠️ devops) mark in the title with instructions to change the product config to the new name.

[mguidon]

Is this the right email address? Or should that go to zmt support?
We already add the zmt forum I guess.

[odeimaiz]

• This image services/static-webserver/client/source/resource/osparc/s4llite_splitimage.png is over 1MB limit per file in our repo.
  The pre-commit hooks should have stop this commit. Does it work in your computer? See

  osparc-simcore/.pre-commit-config.yaml

  Line 10 in 9dfda53

  args: ["--maxkb=1024"]

Is there any chance to move these images to another repo and use links to them?

I reduced the file size.

[odeimaiz]

Is this the right email address? Or should that go to zmt support? We already add the zmt forum I guess.

All that information goes in the DB

[pcrespov]

cool!

Q: If we had a content server deployed (as ITISFoundation/osparc-issues#702). We would not need to add these files here, right? Just to be sure I understand it right.

Do not forget to add (⚠️ devops) mark in the title with instructions to change the product config to the new name.

[odeimaiz]

cool!

Q: If we had a content server deployed (as ITISFoundation/osparc-issues#702). We would not need to add these files here, right? Just to be sure I understand it right.

Do not forget to add (⚠️ devops) mark in the title with instructions to change the product config to the new name.

Correct

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[mrnicegyu11]

looks lite