Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fixes flaky test_update_profile and cleanup tests #3528

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 8, 2022

What do these changes do?

tests/unit/with_dbs/03/test_users.py::test_update_profile[UserRole.USER-HTTPNoContent] failed

  • when the faker includes a . (dot) in the user_name, the update does not work well. It is an strange case but thanks to the faker it popped up (similar to hypothesis)

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #3528 (6d8d9dc) into master (4607b36) will decrease coverage by 5.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3528     +/-   ##
========================================
- Coverage    83.4%   78.1%   -5.3%     
========================================
  Files         848     848             
  Lines       35779   35779             
  Branches      748     748             
========================================
- Hits        29851   27965   -1886     
- Misses       5737    7623   +1886     
  Partials      191     191             
Flag Coverage Δ
integrationtests 62.4% <ø> (-5.0%) ⬇️
unittests 78.4% <ø> (-2.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) ⬇️
...rc/simcore_service_director_v2/utils/dict_utils.py 16.1% <0.0%> (-83.9%) ⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py 22.2% <0.0%> (-77.8%) ⬇️
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) ⬇️
...tor_v2/modules/dynamic_sidecar/docker_api/_core.py 26.5% <0.0%> (-69.8%) ⬇️
...s/dynamic_sidecar/docker_service_specs/settings.py 13.6% <0.0%> (-67.4%) ⬇️
...r_v2/modules/dynamic_sidecar/docker_api/_volume.py 35.5% <0.0%> (-62.8%) ⬇️
... and 76 more

@pcrespov pcrespov self-assigned this Nov 8, 2022
@pcrespov pcrespov changed the title ♻️ Maintenance/refactor testing ♻️ Fixes flaky test_update_profile and cleanup tests Nov 8, 2022
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Nov 8, 2022
@pcrespov pcrespov added this to the TheNExtMileston milestone Nov 8, 2022
@pcrespov pcrespov marked this pull request as ready for review November 8, 2022 12:54
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only skimmed over the changes, looks good on first sight, thanks a lot!

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good! thanks for cleaning up!

@pcrespov pcrespov force-pushed the maintenance/refactor-testing branch from 7abeca7 to be3fb01 Compare November 8, 2022 15:01
@pcrespov pcrespov force-pushed the maintenance/refactor-testing branch from be3fb01 to 6d8d9dc Compare November 9, 2022 00:43
@pcrespov pcrespov enabled auto-merge (squash) November 9, 2022 00:44
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit e7eada1 into ITISFoundation:master Nov 9, 2022
@pcrespov pcrespov deleted the maintenance/refactor-testing branch November 15, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants