-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Fixes flaky test_update_profile and cleanup tests #3528
♻️ Fixes flaky test_update_profile and cleanup tests #3528
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3528 +/- ##
========================================
- Coverage 83.4% 78.1% -5.3%
========================================
Files 848 848
Lines 35779 35779
Branches 748 748
========================================
- Hits 29851 27965 -1886
- Misses 5737 7623 +1886
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only skimmed over the changes, looks good on first sight, thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good! thanks for cleaning up!
7abeca7
to
be3fb01
Compare
be3fb01
to
6d8d9dc
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
from _pytest.*
importstests/unit/with_dbs/03/test_users.py::test_update_profile[UserRole.USER-HTTPNoContent]
tests/unit/with_dbs/03/test_users.py::test_update_profile[UserRole.USER-HTTPNoContent]
failed.
(dot) in the user_name, the update does not work well. It is an strange case but thanks to thefaker
it popped up (similar to hypothesis)Related issue/s
How to test
Checklist