Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛✨ Frontend: S4L Light product II #3508

Merged
merged 24 commits into from
Nov 3, 2022
Merged

🐛✨ Frontend: S4L Light product II #3508

merged 24 commits into from
Nov 3, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 3, 2022 •
edited
Loading

What do these changes do?

  • In order to keep users in full screen mode and hide the workbench, the restore/maximize button has been excluded from all iframes (includes bugfix).
  • e2e test added

(2D plot is started because I can't start a sim4life-dy)
maximizeButton

Related issue/s

related to ITISFoundation/osparc-issues#740

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Nov 3, 2022
@odeimaiz odeimaiz added this to the Katherine Switzer milestone Nov 3, 2022
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🎨enhancement labels Nov 3, 2022
@odeimaiz odeimaiz marked this pull request as ready for review November 3, 2022 12:51
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pcrespov
pcrespov reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz requested a review from mguidon November 3, 2022 15:59
@odeimaiz odeimaiz changed the title ✨ Frontend: S4L Light product II 🐛✨ Frontend: S4L Light product II Nov 3, 2022
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Nov 3, 2022
@odeimaiz odeimaiz merged commit 187f59e into ITISFoundation:master Nov 3, 2022
@odeimaiz odeimaiz deleted the feature/s4l-light-II branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@sanderegg sanderegg sanderegg approved these changes

@elisabettai elisabettai elisabettai approved these changes

@GitHK GitHK Awaiting requested review from GitHK

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@mguidon mguidon Awaiting requested review from mguidon

@colinRawlings colinRawlings Awaiting requested review from colinRawlings

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Katherine Switzer
Development

Successfully merging this pull request may close these issues.
4 participants
@odeimaiz @elisabettai @pcrespov @sanderegg