♻️ Maintenance: Removed deprecation warnings and marks flaky tests #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3085 +/- ##
========================================
+ Coverage 79.2% 81.0% +1.8%
========================================
Files 716 715 -1
Lines 30924 30922 -2
Branches 4035 4035
========================================
+ Hits 24494 25052 +558
+ Misses 5524 4989 -535
+ Partials 906 881 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
../../.venv/lib/python3.9/site-packages/pytest_aiohttp/plugin.py:28
/home/crespo/devp/osparc-simcore/.venv/lib/python3.9/site-packages/pytest_aiohttp/plugin.py:28: DeprecationWarning: The 'asyncio_mode' is 'legacy', switching to 'auto' for the sake of pytest-aiohttp backward compatibility. Please explicitly use 'asyncio_mode=strict' or 'asyncio_mode=auto' in pytest configuration file.
config.issue_config_time_warning(LEGACY_MODE, stacklevel=2)
…ated, use instead settings_library.http_client_request
pcrespov
force-pushed
the
maintenance/week-22
branch
from
be5899e
to
1c5615a
Compare
…t at 0x7fa4f7aec850>. See https://www.python-httpx.org/async/\#opening-and-closing-clients for details.
…marked with '@pytest.mark.asyncio' but it is not an async function. Please remove asyncio marker. If the test is not marked explicitly, check for global markers applied via 'pytestmark'.
…yptography 37.0.0
pcrespov
changed the title
pcrespov
changed the title
sanderegg
approved these changes
Jun 9, 2022
|
|
||
|
|
||
| async def close_director(app: FastAPI) -> None: | ||
| if director_client := app.state.director_api: | ||
| await director_client.delete() | ||
| client: Optional[DirectorApi] |
There was a problem hiding this comment.
what is the point of declaring this variable?
There was a problem hiding this comment.
this way we can get autocompletion, search, etc in vscode
| @@ -6,3 +6,6 @@ tag = False | |||
| commit_args = --no-verify | |||
|
|
|||
| [bumpversion:file:VERSION] | |||
|
|
|||
| [tool:pytest] | |||
| asyncio_mode = auto | |||
There was a problem hiding this comment.
why was this necessary? it is already in the makefile right?
There was a problem hiding this comment.
is it? I need to double check then. There was a warning in the tests ...
../../.venv/lib/python3.9/site-packages/pytest_aiohttp/plugin.py:28
/home/crespo/devp/osparc-simcore/.venv/lib/python3.9/site-packages/pytest_aiohttp/plugin.py:28: DeprecationWarning: The 'asyncio_mode' is 'legacy', switching to 'auto' for the sake of pytest-aiohttp backward compatibility. Please explicitly use 'asyncio_mode=strict' or 'asyncio_mode=auto' in pytest configuration file.
config.issue_config_time_warning(LEGACY_MODE, stacklevel=2)
There was a problem hiding this comment.
But yes, I see that the scripts in ci and the makefile recipes incorporate this option in CLI
That is strange then. Perhaps I was running pytest manually via CLI.
GitHK
reviewed
Jun 9, 2022
GitHK
requested changes
Jun 10, 2022
* fixed test * refactor test Co-authored-by: Andrei Neagu <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Misc maintenance: Various minor issues in the repo.
Mostly warnings displayed during test or execution
test_context_aware_measure_parallelis@GitHK please checkThe 'asyncio_mode' is 'legacy', switching to 'auto' for the sake of pytest-aiohttp backward compatibility. Please explicitly use 'asyncio_mode=strict' or 'asyncio_mode=auto' in pytest configuration fileby adding configuration insetup.cfgmodels_library.settings(now should usesettings_libraryinstead)paramikoto avoid Warnings due to Blowfish deprecation in cryptographypostgres-database🧪
service-library🧪
web🧪
Legend: