Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Is353/api results table from meta-project sweep (⚠️ devops) #2851

Merged
merged 20 commits into from
Mar 7, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 24, 2022

What do these changes do?

This PR adds new entrypoints in the API to retrieve the iterations results. An iteration result basically contains the values produced (e.g. iterator) and observed (probes) in the iteration working copy project.

The webserver API introduces a new entry to list all results of a meta-project. Returns a table-like json with information about valuds produced and observer. This is the third entry in this view:

image

Next PRs

  • Access to some of the meta entrypoints above via api-server e.g. to create/retrieve results from different projects
  • Run functional nodes in computational backend

Extras

  • Re-enables access to /dev/docs (both reverse proxy and web-server settings) by default. SEE additions in trafik rules in services/docker-compose.yml (⚠️ devops)

Related issue/s

How to test

cd osparc-simcore
make devenv
source .venv/bin/activate
cd services/web/server 
make install-dev
pytest --pdb -vv tests/**/meta_mode*.py

Checklist

  • test results in workflow test
  • add access in server-api (separated PR?)
  • Openapi changes? make openapi-specs, git commit ... and then make version-*)
  • Database migration script? cd packages/postgres-database, make setup-commit, sc-pg review -m "my changes"
  • Unit tests for the changes exist
  • Runs in the swarm
  • Documentation reflects the changes
  • New module? Add your github username to .github/CODEOWNERS

@pcrespov pcrespov self-assigned this Feb 24, 2022
@pcrespov pcrespov added this to the R.Schumann milestone Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #2851 (2f5278d) into master (0df1384) will increase coverage by 16.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2851      +/-   ##
=========================================
+ Coverage    72.8%   89.2%   +16.4%     
=========================================
  Files         672      26     -646     
  Lines       27482     531   -26951     
  Branches     3206      48    -3158     
=========================================
- Hits        20008     474   -19534     
+ Misses       6824      46    -6778     
+ Partials      650      11     -639     
Flag Coverage Δ
unittests 89.2% <ø> (+16.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imcore_service_webserver/meta_modeling_handlers.py
...core_service_webserver/meta_modeling_iterations.py
...service_webserver/meta_modeling_version_control.py
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py
...rector_v2/modules/comp_scheduler/dask_scheduler.py
...base/src/simcore_postgres_database/models/users.py
...core_service_api_server/api/routes/solvers_jobs.py
.../director/src/simcore_service_director/producer.py
...re_service_director_v2/models/schemas/constants.py
...imcore_service_webserver/exporter/async_hashing.py
... and 636 more

@pcrespov pcrespov force-pushed the is353/api-params-table branch 3 times, most recently from 0ecb42d to 8dedc91 Compare March 1, 2022 17:02
@pcrespov pcrespov marked this pull request as ready for review March 1, 2022 17:09
@pcrespov pcrespov changed the title ✨ Is353/api params table ✨ Is353/api results table from meta-project sweep Mar 1, 2022
@pcrespov pcrespov added a:apiserver api-server service a:catalog catalog service labels Mar 1, 2022
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking nice.
Due to lack of familiarity with this feature, I have some questions below.

@pcrespov pcrespov changed the title ✨ Is353/api results table from meta-project sweep ✨ Is353/api results table from meta-project sweep (⚠️ devops) Mar 2, 2022
@KZzizzle
Copy link
Contributor

KZzizzle commented Mar 2, 2022

good to know, thanks!

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

services/docker-compose.yml Outdated Show resolved Hide resolved
@@ -228,7 +228,7 @@ services:
- traefik.http.services.${SWARM_STACK_NAME}_webserver.loadbalancer.sticky.cookie.secure=true
- traefik.http.middlewares.${SWARM_STACK_NAME}_webserver_retry.retry.attempts=2
- traefik.http.routers.${SWARM_STACK_NAME}_webserver.service=${SWARM_STACK_NAME}_webserver
- traefik.http.routers.${SWARM_STACK_NAME}_webserver.rule=hostregexp(`{host:.+}`) && (Path(`/`, `/v0`,`/socket.io/`,`/static-frontend-data.json`, `/study/{study_uuid:\b[0-9a-f]{8}\b-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-\b[0-9a-f]{12}\b}`, `/view`, `/#/view`, `/#/error`) || PathPrefix(`/v0/`))
- traefik.http.routers.${SWARM_STACK_NAME}_webserver.rule=hostregexp(`{host:.+}`) && (Path(`/`, `/v0`,`/socket.io/`,`/static-frontend-data.json`, `/study/{study_uuid:\b[0-9a-f]{8}\b-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-\b[0-9a-f]{12}\b}`, `/view`, `/#/view`, `/#/error`) || PathPrefix(`/v0/`, `/dev/`))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so I had a quick look in the deploy repository and this will open the dev/doc to anyone. let's discuss if that is the wanted behaviour

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanderegg so at the end PathPrefix(/v0/, /dev/) was added in docker-compose.local.yml (i.e. for local development) so it should NOT collide with compose-spec file added in operations.

@pcrespov pcrespov merged commit 7cf097b into ITISFoundation:master Mar 7, 2022
@pcrespov pcrespov deleted the is353/api-params-table branch March 7, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service a:catalog catalog service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants