-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Is353/api results table from meta-project sweep (⚠️ devops) #2851
✨ Is353/api results table from meta-project sweep (⚠️ devops) #2851
Conversation
0ecb42d
to
8dedc91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice.
Due to lack of familiarity with this feature, I have some questions below.
services/web/server/src/simcore_service_webserver/meta_modeling_handlers.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/meta_modeling_results.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/meta_modeling_results.py
Outdated
Show resolved
Hide resolved
good to know, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
2c5567e
to
2f79dc5
Compare
services/docker-compose.yml
Outdated
@@ -228,7 +228,7 @@ services: | |||
- traefik.http.services.${SWARM_STACK_NAME}_webserver.loadbalancer.sticky.cookie.secure=true | |||
- traefik.http.middlewares.${SWARM_STACK_NAME}_webserver_retry.retry.attempts=2 | |||
- traefik.http.routers.${SWARM_STACK_NAME}_webserver.service=${SWARM_STACK_NAME}_webserver | |||
- traefik.http.routers.${SWARM_STACK_NAME}_webserver.rule=hostregexp(`{host:.+}`) && (Path(`/`, `/v0`,`/socket.io/`,`/static-frontend-data.json`, `/study/{study_uuid:\b[0-9a-f]{8}\b-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-\b[0-9a-f]{12}\b}`, `/view`, `/#/view`, `/#/error`) || PathPrefix(`/v0/`)) | |||
- traefik.http.routers.${SWARM_STACK_NAME}_webserver.rule=hostregexp(`{host:.+}`) && (Path(`/`, `/v0`,`/socket.io/`,`/static-frontend-data.json`, `/study/{study_uuid:\b[0-9a-f]{8}\b-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-\b[0-9a-f]{12}\b}`, `/view`, `/#/view`, `/#/error`) || PathPrefix(`/v0/`, `/dev/`)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so I had a quick look in the deploy repository and this will open the dev/doc to anyone. let's discuss if that is the wanted behaviour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanderegg so at the end PathPrefix(/v0/
, /dev/
) was added in docker-compose.local.yml (i.e. for local development) so it should NOT collide with compose-spec file added in operations.
2f79dc5
to
319acd2
Compare
What do these changes do?
This PR adds new entrypoints in the API to retrieve the iterations results. An iteration result basically contains the values produced (e.g. iterator) and observed (probes) in the iteration working copy project.
The webserver API introduces a new entry to list all results of a meta-project. Returns a table-like json with information about valuds produced and observer. This is the third entry in this view:
Next PRs
Extras
/dev/docs
(both reverse proxy and web-server settings) by default. SEE additions in trafik rules inservices/docker-compose.yml
(Related issue/s
How to test
Checklist
make openapi-specs
,git commit ...
and thenmake version-*
)cd packages/postgres-database
,make setup-commit
,sc-pg review -m "my changes"