Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "please wait" message when Nature services are starting #2801

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 7, 2022

What do these changes do?

Demo showing the message in the 2D plot service:
MightTakeLong

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Feb 7, 2022
@odeimaiz odeimaiz added this to the Rudolph+1 milestone Feb 7, 2022
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #2801 (8e45b97) into master (48d28c1) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2801     +/-   ##
========================================
- Coverage    78.8%   78.8%   -0.1%     
========================================
  Files         670     670             
  Lines       27186   27186             
  Branches     2669    2669             
========================================
- Hits        21445   21440      -5     
- Misses       4982    4986      +4     
- Partials      759     760      +1     
Flag Coverage Δ
integrationtests 65.9% <ø> (-0.1%) ⬇️
unittests 74.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vice_director_v2/modules/dynamic_sidecar/errors.py 82.6% <0.0%> (-17.4%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 94.1% <0.0%> (-1.8%) ⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py 80.7% <0.0%> (-1.5%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 82.6% <0.0%> (+0.6%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 73.5% <0.0%> (+0.8%) ⬆️
...simcore_service_webserver/projects/project_lock.py 100.0% <0.0%> (+5.2%) ⬆️

Copy link
Contributor

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant

@odeimaiz odeimaiz merged commit e8ee617 into ITISFoundation:master Feb 7, 2022
@odeimaiz odeimaiz deleted the feature/slow-start branch February 7, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants