-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show "please wait" message when Nature services are starting #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
requested review from
colinRawlings,
esraneufeld,
GitHK,
ignapas,
KZzizzle,
mguidon,
newton1985 and
pcrespov
February 7, 2022 11:36
Codecov Report
@@ Coverage Diff @@
## master #2801 +/- ##
========================================
- Coverage 78.8% 78.8% -0.1%
========================================
Files 670 670
Lines 27186 27186
Branches 2669 2669
========================================
- Hits 21445 21440 -5
- Misses 4982 4986 +4
- Partials 759 760 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
KZzizzle
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brilliant
mguidon
approved these changes
Feb 7, 2022
newton1985
approved these changes
Feb 7, 2022
mrnicegyu11
approved these changes
Feb 7, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Demo showing the message in the 2D plot service:
Related issue/s
How to test
Checklist