Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ upgrades pydantic==1.9.0 repo-wide #2752

Merged
merged 12 commits into from
Jan 21, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 20, 2022

What do these changes do?

Upgrades to pydantic==1.9.0 the entire repo except for the director service (frozen and waiting to be replaced )

Related issue/s

ITISFoundation-issues#428

How to test

Checklist

@pcrespov pcrespov requested a review from GitHK as a code owner January 20, 2022 13:15
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #2752 (0c92ab7) into master (67a91d5) will increase coverage by 0.0%.
The diff coverage is 85.7%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2752   +/-   ##
======================================
  Coverage    79.1%   79.1%           
======================================
  Files         677     677           
  Lines       27018   27001   -17     
  Branches     2618    2616    -2     
======================================
+ Hits        21373   21380    +7     
+ Misses       4912    4890   -22     
+ Partials      733     731    -2     
Flag Coverage Δ
integrationtests 65.6% <ø> (+<0.1%) ⬆️
unittests 74.9% <85.7%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dels-library/src/models_library/rest_pagination.py 96.5% <ø> (+3.4%) ⬆️
...erver/src/simcore_service_webserver/application.py 98.7% <ø> (-0.1%) ⬇️
...ettings-library/src/settings_library/prometheus.py 91.6% <50.0%> (ø)
...src/dask_task_models_library/container_tasks/io.py 100.0% <100.0%> (ø)
...es/models-library/src/models_library/utils/misc.py 100.0% <100.0%> (ø)
...er/src/simcore_service_api_server/core/settings.py 98.3% <100.0%> (-0.1%) ⬇️
...simcore_service_webserver/projects/project_lock.py 94.7% <0.0%> (-5.3%) ⬇️
.../src/simcore_service_webserver/statics_settings.py 94.2% <0.0%> (-2.9%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 86.6% <0.0%> (-0.6%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 82.1% <0.0%> (+0.6%) ⬆️
... and 5 more

@pcrespov pcrespov self-assigned this Jan 20, 2022
@pcrespov pcrespov added t:maintenance Some planned maintenance work changelog:ignore-for-release labels Jan 20, 2022
@pcrespov pcrespov marked this pull request as draft January 20, 2022 13:21
@pcrespov pcrespov changed the title ⬆️ upgrades pydantic==1.9.0 repo-wide WIP: ⬆️ upgrades pydantic==1.9.0 repo-wide Jan 20, 2022
@pcrespov pcrespov changed the title WIP: ⬆️ upgrades pydantic==1.9.0 repo-wide ⬆️ upgrades pydantic==1.9.0 repo-wide Jan 20, 2022
@pcrespov pcrespov marked this pull request as ready for review January 20, 2022 23:39
@pcrespov pcrespov added this to the Rudolph milestone Jan 21, 2022
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice, finally removed the monkey patch

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dark mode power!

@pcrespov pcrespov merged commit 5696d9f into ITISFoundation:master Jan 21, 2022
@pcrespov pcrespov deleted the maintenance/pydantic-update branch January 21, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants