-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update All services with one click #2721
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
========================================
+ Coverage 78.0% 78.1% +0.1%
========================================
Files 643 643
Lines 26391 26391
Branches 2555 2555
========================================
+ Hits 20585 20621 +36
+ Misses 5108 5081 -27
+ Partials 698 689 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it! thanks for the present!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
THOUGHT: Still updates the latest patch, right?
From https://semver.org/
Given a version number MAJOR.MINOR.PATCH, increment the:
- MAJOR version when you make incompatible API changes,
- MINOR version when you add functionality in a backwards compatible manner, and
- PATCH version when you make backwards compatible bug fixes.
Should we add an option to select what sort of upgrade as well? At least for MINOR?
Correct, for now, it only applies to Patches. A Minor upgrade in the service might involve updates in the ports (new port, updates on units....) and this would break connections. I'm not sure you want to go that far. |
@odeimaiz a minor upgrade should be backwards compatible ( read definitions above) -> no interface change expected! We could eventually enforce that in the service library test when we evaluate services |
What do these changes do?
Related issue/s
closes ITISFoundation/osparc-issues#572
How to test
Checklist