Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update All services with one click #2721

Merged
merged 5 commits into from
Jan 7, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jan 7, 2022

What do these changes do?

UpdateAll

Related issue/s

closes ITISFoundation/osparc-issues#572

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jan 7, 2022
@odeimaiz odeimaiz added this to the Rudolph milestone Jan 7, 2022
@odeimaiz odeimaiz self-assigned this Jan 7, 2022
@odeimaiz odeimaiz changed the title Feature/hasten Update All services with one click Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #2721 (1e26daf) into master (5903c51) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2721     +/-   ##
========================================
+ Coverage    78.0%   78.1%   +0.1%     
========================================
  Files         643     643             
  Lines       26391   26391             
  Branches     2555    2555             
========================================
+ Hits        20585   20621     +36     
+ Misses       5108    5081     -27     
+ Partials      698     689      -9     
Flag Coverage Δ
integrationtests 67.0% <ø> (-0.1%) ⬇️
unittests 73.8% <ø> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py 68.7% <0.0%> (-1.9%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 93.6% <0.0%> (-1.5%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 85.9% <0.0%> (-0.6%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 87.2% <0.0%> (+0.5%) ⬆️
...simcore_service_webserver/projects/projects_api.py 88.4% <0.0%> (+0.7%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 91.7% <0.0%> (+1.0%) ⬆️
.../simcore_service_webserver/projects/projects_db.py 90.7% <0.0%> (+1.1%) ⬆️
...mcore_service_webserver/projects/projects_utils.py 80.5% <0.0%> (+4.2%) ⬆️
...re_service_webserver/projects/projects_handlers.py 83.3% <0.0%> (+12.1%) ⬆️

@odeimaiz odeimaiz marked this pull request as ready for review January 7, 2022 09:59
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it! thanks for the present!!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

THOUGHT: Still updates the latest patch, right?

From https://semver.org/

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes,
  2. MINOR version when you add functionality in a backwards compatible manner, and
  3. PATCH version when you make backwards compatible bug fixes.

Should we add an option to select what sort of upgrade as well? At least for MINOR?

@odeimaiz
Copy link
Member Author

odeimaiz commented Jan 7, 2022

Great!

THOUGHT: Still updates the latest patch, right?

From https://semver.org/

Given a version number MAJOR.MINOR.PATCH, increment the:

  1. MAJOR version when you make incompatible API changes,
  2. MINOR version when you add functionality in a backwards compatible manner, and
  3. PATCH version when you make backwards compatible bug fixes.

Should we add an option to select what sort of upgrade as well? At least for MINOR?

Correct, for now, it only applies to Patches.

A Minor upgrade in the service might involve updates in the ports (new port, updates on units....) and this would break connections. I'm not sure you want to go that far.

@odeimaiz odeimaiz merged commit c486627 into ITISFoundation:master Jan 7, 2022
@odeimaiz odeimaiz deleted the feature/hasten branch January 7, 2022 11:52
@pcrespov
Copy link
Member

pcrespov commented Jan 7, 2022

A Minor upgrade in the service might involve updates in the ports (new port, updates on units....) and this would break connections. I'm not sure you want to go that far.

@odeimaiz a minor upgrade should be backwards compatible ( read definitions above) -> no interface change expected! We could eventually enforce that in the service library test when we evaluate services

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable update of all services with one click
3 participants