Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Handling of staging hotfixes #2649

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 18, 2021

What do these changes do?

Adds the option to create a staging-hotfix release by following the same rules as for release-hotfixes:

  • create a branch named such as staging_meerkat2
  • wait for the CI to complete the normal build -> will generate images named such as webserver:hotfix-staging-github-latest and webserver:hotfix-staging-github-DATE-SHA
  • if ok, then using make release-hotfix-staging creates a TAG that the github CI will pickup
  • the CI will then rename the previously created images to staging-github-latest so that it gets deployed

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #2649 (1029639) into master (ff21b4a) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2649   +/-   ##
======================================
  Coverage    77.1%   77.1%           
======================================
  Files         625     625           
  Lines       25148   25148           
  Branches     2475    2475           
======================================
+ Hits        19392   19398    +6     
+ Misses       5112    5109    -3     
+ Partials      644     641    -3     
Flag Coverage Δ
integrationtests 65.0% <ø> (+<0.1%) ⬆️
unittests 73.0% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 62.1% <0.0%> (+0.4%) ⬆️
...ce_webserver/resource_manager/garbage_collector.py 76.4% <0.0%> (+0.8%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 90.4% <0.0%> (+1.1%) ⬆️
...rc/simcore_service_director_v2/modules/rabbitmq.py 89.4% <0.0%> (+1.7%) ⬆️

@sanderegg sanderegg assigned GitHK, odeimaiz and pcrespov and unassigned GitHK, odeimaiz and pcrespov Nov 18, 2021
@sanderegg sanderegg self-assigned this Nov 18, 2021
@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Nov 18, 2021
@sanderegg sanderegg added this to the Meerkat milestone Nov 18, 2021
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice addition

@sanderegg sanderegg merged commit 6a83032 into ITISFoundation:master Nov 18, 2021
@sanderegg sanderegg deleted the maintenance/add_staging_hotfixes_facilities branch November 18, 2021 14:15
pcrespov pushed a commit that referenced this pull request Nov 18, 2021
pcrespov added a commit to pcrespov/osparc-simcore that referenced this pull request Nov 18, 2021
pcrespov added a commit that referenced this pull request Nov 18, 2021
* fixes recipe for hotfix from PR #2649
* fixes ci staging used for staging hotfixes
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Dec 6, 2021
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Dec 6, 2021
* fixes recipe for hotfix from PR ITISFoundation#2649
* fixes ci staging used for staging hotfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants