Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ Is2392/restore project snaphots #2534

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 9, 2021

What do these changes do?

IN order to have a running demo for Monday in master, @odeimaiz and me decided to restore former project-snapshots concept (yellow) until the new design (red) is fully functional.

This feature is only enabled in master (with WEBSERVER_DEV_FEATURES_ENABLED=1 ) and accessible to TESTER users. Since it is a dev-feature, all data created in these tables will be dumped when the new design is in place

  • restores projects_snapshots table
    Screen Shot 2021-09-09 at 18 12 25

  • restores CRUD operations on /projects/*/snapshots resource
    image

  • @odeimaiz , notice that now you have update as well. Please review interaction with the front-end.

Related issue/s

How to test

make devenv
source .venv/bin/activate
cd services/web/server
make install-dev
pytest tests/unit/with_dbs/10/snapshots

@pcrespov pcrespov self-assigned this Sep 9, 2021
@pcrespov pcrespov added a:database associated to postgres service and postgres-database package a:webserver issue related to the webserver service labels Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2534 (47377f0) into master (963fbd1) will increase coverage by 0.5%.
The diff coverage is 93.9%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2534     +/-   ##
========================================
+ Coverage    76.5%   77.0%   +0.5%     
========================================
  Files         610     611      +1     
  Lines       23397   23445     +48     
  Branches     2294    2297      +3     
========================================
+ Hits        17918   18076    +158     
+ Misses       4872    4764    -108     
+ Partials      607     605      -2     
Flag Coverage Δ
integrationtests 66.3% <47.5%> (-0.1%) ⬇️
unittests 71.4% <93.9%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...imcore_service_webserver/snapshots_api_handlers.py 85.0% <90.7%> (+43.7%) ⬆️
...ore_postgres_database/models/projects_snapshots.py 100.0% <100.0%> (ø)
...rver/src/simcore_service_webserver/snapshots_db.py 91.0% <100.0%> (+39.1%) ⬆️
.../src/simcore_service_webserver/snapshots_models.py 100.0% <100.0%> (+7.4%) ⬆️
...simcore_service_director_v2/modules/dask_client.py 90.8% <0.0%> (-3.4%) ⬇️
...ector_v2/modules/comp_scheduler/background_task.py 92.1% <0.0%> (-2.0%) ⬇️
.../director/src/simcore_service_director/producer.py 62.3% <0.0%> (+0.6%) ⬆️
...or_v2/models/schemas/dynamic_services/scheduler.py 97.2% <0.0%> (+0.6%) ⬆️
...simcore_service_webserver/projects/projects_api.py 84.8% <0.0%> (+1.8%) ⬆️
... and 9 more

@pcrespov pcrespov requested a review from sanderegg September 9, 2021 16:56
@pcrespov pcrespov force-pushed the is2392/restore-project-snaphots branch from 1b303e4 to cd41756 Compare September 9, 2021 16:59
@pcrespov pcrespov marked this pull request as ready for review September 9, 2021 16:59
@pcrespov pcrespov changed the title ⚗️ WIP: Is2392/restore project snaphots ⚗️ Is2392/restore project snaphots Sep 9, 2021
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz mentioned this pull request Sep 10, 2021
2 tasks
@odeimaiz odeimaiz merged commit e31b783 into ITISFoundation:master Sep 10, 2021
@pcrespov pcrespov deleted the is2392/restore-project-snaphots branch September 10, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:database associated to postgres service and postgres-database package a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants