Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance/reduce num unittests #2525

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 3, 2021

What do these changes do?

Reduce the number of jobs of the CI, since the webserver ones are now faster.
This should provide more machines available to other PRs.

Related issue/s

How to test

Checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Sep 3, 2021
@sanderegg sanderegg added this to the Chevrotain milestone Sep 3, 2021
@sanderegg sanderegg self-assigned this Sep 3, 2021
@sanderegg sanderegg force-pushed the maintenance/reduce_num_unittests branch from 65d6d60 to 5364ece Compare September 3, 2021 07:21
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #2525 (6b3e82b) into master (754fe5a) will decrease coverage by 4.0%.
The diff coverage is 25.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2525     +/-   ##
========================================
- Coverage    76.9%   72.8%   -4.1%     
========================================
  Files         622     575     -47     
  Lines       24028   22561   -1467     
  Branches     2355    2177    -178     
========================================
- Hits        18478   16442   -2036     
- Misses       4922    5587    +665     
+ Partials      628     532     -96     
Flag Coverage Δ
integrationtests 78.6% <ø> (+13.1%) ⬆️
unittests 69.2% <25.0%> (-2.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/src/simcore_service_webserver/groups_handlers.py 28.9% <0.0%> (-35.4%) ⬇️
...server/src/simcore_service_webserver/groups_api.py 32.4% <33.3%> (-59.2%) ⬇️
...simcore_service_webserver/computation_subscribe.py 30.0% <0.0%> (-61.3%) ⬇️
...imcore_service_webserver/exporter/export_import.py 34.1% <0.0%> (-61.0%) ⬇️
...vice_webserver/exporter/formatters/formatter_v2.py 31.9% <0.0%> (-56.4%) ⬇️
...vice_webserver/exporter/formatters/formatter_v1.py 24.5% <0.0%> (-54.2%) ⬇️
...c/simcore_service_webserver/users_to_groups_api.py 46.1% <0.0%> (-53.9%) ⬇️
...rc/simcore_service_webserver/login/confirmation.py 33.3% <0.0%> (-47.3%) ⬇️
...src/simcore_service_webserver/groups_exceptions.py 53.3% <0.0%> (-46.7%) ⬇️
... and 86 more

@sanderegg sanderegg force-pushed the maintenance/reduce_num_unittests branch 2 times, most recently from 59c7dfd to 944c4f0 Compare September 10, 2021 11:03
@sanderegg sanderegg force-pushed the maintenance/reduce_num_unittests branch 4 times, most recently from e9c4803 to 5e049f1 Compare September 17, 2021 07:09
@sanderegg sanderegg force-pushed the maintenance/reduce_num_unittests branch 3 times, most recently from 95835f8 to 841ca39 Compare September 27, 2021 15:36
@sanderegg
Copy link
Member Author

not a priority

@sanderegg sanderegg closed this Feb 4, 2022
@sanderegg sanderegg deleted the maintenance/reduce_num_unittests branch February 4, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants