-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshots in frontend #2474
Snapshots in frontend #2474
Conversation
This reverts commit 78bdea4.
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
========================================
+ Coverage 71.1% 76.3% +5.1%
========================================
Files 600 600
Lines 22806 22806
Branches 2202 2202
========================================
+ Hits 16228 17405 +1177
+ Misses 6071 4815 -1256
- Partials 507 586 +79
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I try to create a snapshot I get this 404 from the backend.
"GET /v0/projects/efa37dbe-04a7-11ec-a0c1-02420a000008/snapshots HTTP/1.1" 404 378 [7884us]
And what does the backend say? |
That's from the backend, nothing more in the logs. |
ok... let's see if it's only you |
Just as a note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested. looks very nice.
One thing I am not sure if that is expected. When I create a snapshot I get a POST 404. is that expected?
I have set in .env CATALOG_DEV_FEATURES_ENABLED=1
is there anything else to be done?
The error is the following:
http://192.168.1.20.nip.io:9081/v0/projects/e255fa2c-0634-11ec-bfb1-02420a000099/snapshots?snapshot_label=let%27s%20create%20snapshots
{"data": null, "error": {"logs": [{"message": "Not Found", "level": "ERROR", "logger": "user"}], "errors": [{"code": "HTTPNotFound", "message": "Not Found", "resource": null, "field": null}], "status": 404}}
And re-opening the same study gives me the same error that @GitHK reported. so the backend is not enabled or is this something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so it works. Maybe for next time it might be useful for reviewer to add the following instructions in "how to test":
echo WEBSERVER_DEV_FEATURES_ENABLED=1 >> .env
echo CATALOG_DEV_FEATURES_ENABLED=1 >> .env
now everything seems to work pretty nicely!!
Thanks Sylvain 💪, I don't think the CATALOG flag has to be set to 1 for this PR, but, anyway, it would be even better if all the devs flags would automatically be set to 1 in master and dev deployments. |
What do these changes do?
This PR brings the Snapshots concept to the frontend:
... and removes the logic from the frontend for creating parameters and sweeps
Related issue/s
related to ITISFoundation/osparc-issues#328
related to #2392
How to test
Checklist