Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: wait for all templates #2299

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 27, 2021

What do these changes do?

e2e: Wait until all templates reach the frontend before starting one.

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Apr 27, 2021
@odeimaiz odeimaiz added this to the Schwarznasenschaf milestone Apr 27, 2021
@odeimaiz odeimaiz self-assigned this Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #2299 (ab1c2c7) into master (f133e8d) will increase coverage by 4.5%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2299     +/-   ##
========================================
+ Coverage    67.2%   71.8%   +4.5%     
========================================
  Files         505     505             
  Lines       19856   19856             
  Branches     1948    1948             
========================================
+ Hits        13358   14271    +913     
+ Misses       6082    5113    -969     
- Partials      416     472     +56     
Flag Coverage Δ
integrationtests 62.1% <ø> (?)
unittests 67.1% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 61.3% <0.0%> (-0.5%) ⬇️
...re_service_webserver/projects/projects_handlers.py 90.2% <0.0%> (+0.3%) ⬆️
...simcore_service_webserver/director/director_api.py 66.6% <0.0%> (+1.3%) ⬆️
.../simcore_service_webserver/projects/projects_db.py 90.7% <0.0%> (+2.5%) ⬆️
...server/src/simcore_service_webserver/groups_api.py 91.6% <0.0%> (+2.5%) ⬆️
.../server/src/simcore_service_webserver/users_api.py 93.9% <0.0%> (+2.5%) ⬆️
...vices/sidecar/src/simcore_service_sidecar/utils.py 78.0% <0.0%> (+4.0%) ⬆️
...es/sidecar/src/simcore_service_sidecar/rabbitmq.py 89.7% <0.0%> (+4.4%) ⬆️
...erver/src/simcore_service_webserver/director_v2.py 79.5% <0.0%> (+4.5%) ⬆️
...rc/simcore_service_director_v2/core/application.py 88.6% <0.0%> (+4.5%) ⬆️
... and 47 more

@odeimaiz odeimaiz marked this pull request as ready for review April 27, 2021 14:02
@odeimaiz odeimaiz changed the title StudyBrowserButtonLoadMore with ID e2e: wait for all templates Apr 27, 2021
@odeimaiz odeimaiz merged commit 88e383d into ITISFoundation:master Apr 27, 2021
@odeimaiz odeimaiz deleted the e2e/waitForAllTemplates branch August 23, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants