Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 fixes makefile recipe for hotfix-releases #2650

Merged
merged 2 commits into from
Nov 18, 2021

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 18, 2021

What do these changes do?

Both these changes are already included in 🚑️ staging_Meerkat1 and 2 hotfixes

@pcrespov pcrespov self-assigned this Nov 18, 2021
@pcrespov pcrespov added a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work labels Nov 18, 2021
@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #2650 (3eef385) into master (6a83032) will decrease coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2650     +/-   ##
========================================
- Coverage    77.7%   77.0%   -0.7%     
========================================
  Files         625     625             
  Lines       25148   25148             
  Branches     2475    2475             
========================================
- Hits        19542   19387    -155     
- Misses       4959    5115    +156     
+ Partials      647     646      -1     
Flag Coverage Δ
integrationtests 65.0% <ø> (-1.9%) ⬇️
unittests 73.0% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/computation_subscribe.py 27.3% <0.0%> (-68.5%) ⬇️
...rc/simcore_service_webserver/computation_config.py 68.4% <0.0%> (-26.4%) ⬇️
..._service_webserver/projects/projects_exceptions.py 76.1% <0.0%> (-23.9%) ⬇️
...erver/src/simcore_service_webserver/computation.py 76.9% <0.0%> (-23.1%) ⬇️
...webserver/computation_comp_tasks_listening_task.py 60.4% <0.0%> (-23.0%) ⬇️
...simcore_service_webserver/projects/projects_api.py 69.8% <0.0%> (-13.0%) ⬇️
.../src/simcore_service_webserver/director_v2_core.py 61.4% <0.0%> (-4.1%) ⬇️
.../simcore_service_webserver/director_v2_handlers.py 94.8% <0.0%> (-3.5%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 89.0% <0.0%> (-2.1%) ⬇️
...rvice_dynamic_sidecar/modules/directory_watcher.py 92.8% <0.0%> (-1.8%) ⬇️
... and 5 more

@pcrespov pcrespov changed the title fixes makefile recipe for hotfix-releases 👷 fixes makefile recipe for hotfix-releases Nov 18, 2021
@pcrespov pcrespov requested review from sanderegg and GitHK and removed request for sanderegg November 18, 2021 17:58
@pcrespov pcrespov added this to the Meerkat milestone Nov 18, 2021
@pcrespov pcrespov marked this pull request as ready for review November 18, 2021 17:58
@pcrespov pcrespov merged commit c6f42eb into ITISFoundation:master Nov 18, 2021
@pcrespov pcrespov deleted the fix/makefile-hotfix-releases branch November 18, 2021 18:43
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Dec 6, 2021
* fixes recipe for hotfix from PR ITISFoundation#2649
* fixes ci staging used for staging hotfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants