Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mount efs docker volume to efs-guardian #686

Merged
merged 2 commits into from
Jun 4, 2024
Merged

mount efs docker volume to efs-guardian #686

merged 2 commits into from
Jun 4, 2024

Conversation

matusdrobuliak66
Copy link
Contributor

What do these changes do?

  • mount efs docker volume to efs-guardian

Related issue/s

Related PR/s

Checklist

  • I tested and it works

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 3, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Enchanted Odyssey milestone Jun 3, 2024
sanderegg
sanderegg reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering about the networks you put that guy in?
why monitored? does it need to be monitored by prometheus?
why public? is it accessible via traefik?

services/simcore/docker-compose.yml Outdated Show resolved Hide resolved
sanderegg
sanderegg approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

mrnicegyu11
mrnicegyu11 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feuer frei!

services/simcore/docker-compose.yml Show resolved Hide resolved
services/simcore/docker-compose.yml Show resolved Hide resolved
services/simcore/docker-compose.yml Outdated Show resolved Hide resolved
services/simcore/docker-compose.deploy.aws.yml Show resolved Hide resolved
YuryHrytsuk
YuryHrytsuk approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please consider the comments

@matusdrobuliak66 matusdrobuliak66 merged commit f9b3046 into main Jun 4, 2024
4 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the mount-efs-to-efs-guardian-docker-volume branch June 4, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@sanderegg sanderegg sanderegg approved these changes

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels
None yet
Projects
None yet
Milestone
Enchanted Odyssey
Development

Successfully merging this pull request may close these issues.
4 participants
@matusdrobuliak66 @mrnicegyu11 @sanderegg @YuryHrytsuk