-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is1884/using integration library #40
Is1884/using integration library #40
Conversation
9a5397f
to
2d40c36
Compare
804afef
to
68e0821
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot. I see a lot of things hat could be improved:
- non using docker buildX
- in the .gitlab folder there are a few deprecated things
- I guess same is true for .github...
anyway, very very nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very very promising! Looking forward to try it out (I haven't tested yet with your instructions).
What do these changes do?
Simplifies the service project resulting from this cookiecutter by delegating tooling and standard testing to osparc-simcore's service library or
ooil
in short.We have moved most of the code in the cookiecutter to
ooil
library (which lives in osparc-simcore repo). The idea is that there is now a single source of truth : basically themetadata.yml
anddocker-compose-build.yml
files. Thenooil
can deduce everything from it.Next iteration will introduce the
.osparc
folder approach (but one step at time :-) )This leads to a much simpler layout! Just FYI, the resulting service project, compared to the previous version :
tools
folder codeversioning
folderVERSION
files (can be regenerated withooil
assert_*
helper functions (test
skeleton is maintained in this iteration but could be further simplified)ci
to.gitlab
and.github
folders respHow to test
Could you please try this with one of your services? To create a service project using this
cookiecutter + python 3.9
justThen
cd
the "baked" project andRelated issue number
Checklist
source
-ing in asubprocess
! (@sanderegg any idea ontest_bake_project.py
issue?)