Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates cookie-cutter to incorporate new metadata fields in the template #113

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 5, 2024

What do these changes do?

$ source .osparc/bin/acticate
Environment activated. To deactivate, type 'deactivate'
(.osparc) $ ooil --version
1.0.4
(.osparc) $ deactivate
osparc environment deactivated

Related issue/s

How to test

Manual testing:

  • install cc
pip install cookiecutter jinja2_time
  • run cc against this dev branch and answer all prompts
cookiecutter gh:pcrespov/cookiecutter-osparc-service -c is1404/new-version_display
  • cd your project folder
source .osparc/bin/acticate
ooil --version
ooil build
yq e . docker-compose.yml

image

@pcrespov pcrespov self-assigned this Jun 5, 2024
@pcrespov pcrespov added the enhancement New feature or request label Jun 5, 2024
@pcrespov pcrespov changed the title WIP: Is1404/new version display Updates cookie-cutter to incorporate new metadata fields in the template Jun 5, 2024
@pcrespov pcrespov added this to the Leeroy Jenkins milestone Jun 5, 2024
@pcrespov pcrespov marked this pull request as ready for review June 5, 2024 07:53
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice actication... ;)

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

As discussed yesterday, I agree that having a postprocessor that takes care of missing version-display will be useful. I imagine most users of the cookiecutter don't want to specify 2 different versions.

Also a question: have you also set up "recipes" to update version and version-display separately? Or there's no need?

@pcrespov
Copy link
Member Author

pcrespov commented Jun 6, 2024

Also a question: have you also set up "recipes" to update version and version-display separately? Or there's no need?

@elisabettai @mguidon An easy what to go is to add version_display in .cookiecutterrc and then make replay

@pcrespov pcrespov merged commit 1b9c930 into ITISFoundation:master Jun 6, 2024
1 check passed
@pcrespov pcrespov deleted the is1404/new-version_display branch June 6, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants