Feature/irnas zephyr template migration #14
Conversation
github-actions
bot
added
the
pull request
There was a problem hiding this comment.
Looks good I have marked some small things. Some of the requests are probably also relevant to the other two repos, so I will not mention them in the other PRs.
One general thing: Be consistent with the period dots in the comments. Some of them are missing it. Please go through the comments and add them.
.github/workflows/codechecker.yaml
Outdated
| # The retrieve cache job will run only, if the host is not a ubuntu-20.04 runner. | ||
| # GitHub hosted runners begin with 'Github Action' |
There was a problem hiding this comment.
Remove this comment. Please do the same in all similarly relevant places.
.github/workflows/twister.yaml
Outdated
| # This version is a must, twister otherwise fails (some Python library | ||
| # depends on a specific version of libffi that is not present in the | ||
| # toolchain provided by nordic's toolchain manager). | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
This is now not true. The original comment was referring to the ubuntu-20.04, and that was for the twister-build job.
Please place this comment in the docker image inside irnas-runners-software repo, as our self-hosted will be running ubuntu-20.04, so that is the most appropriate place for it (since ubuntu-22.04 and nrftutil-toolchain-manager seem to be incompatible for now).
There was a problem hiding this comment.
Also, above comment starting with WARNING is also not true since job twister-test-results uses ubuntu-22.04 instead of self-hosted. Am I missing something here?
There was a problem hiding this comment.
I see now. Also, I have reworded the warning to be more concise.
NejcKle
force-pushed
the
feature/irnas-zephyr-template-migration
branch
from
f575314 to
998a599
Compare
Description
This PR implements changes required to migrate the workflow files and scripts from the
irnas-runners-softwarerepository to this one andirnas-workflows-software. Some files got moved around and/or to different repositories, see Related below.Changes:
Closes #
Related https://github.com/IRNAS/irnas-runners-software/pull/6 IRNAS/irnas-workflows-software#9
Areas of interest for the reviewer
Check the workflow files and docs.
Checklist
functions.
I updated all customer-facing technical documentation.After-review steps