-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/irnas zephyr template migration #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I have marked some small things. Some of the requests are probably also relevant to the other two repos, so I will not mention them in the other PRs.
One general thing: Be consistent with the period dots in the comments. Some of them are missing it. Please go through the comments and add them.
.github/workflows/codechecker.yaml
Outdated
# The retrieve cache job will run only, if the host is not a ubuntu-20.04 runner. | ||
# GitHub hosted runners begin with 'Github Action' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this comment. Please do the same in all similarly relevant places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked some minor things in the comments
.github/workflows/twister.yaml
Outdated
# This version is a must, twister otherwise fails (some Python library | ||
# depends on a specific version of libffi that is not present in the | ||
# toolchain provided by nordic's toolchain manager). | ||
runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now not true. The original comment was referring to the ubuntu-20.04, and that was for the twister-build
job.
Please place this comment in the docker image inside irnas-runners-software repo, as our self-hosted will be running ubuntu-20.04, so that is the most appropriate place for it (since ubuntu-22.04 and nrftutil-toolchain-manager seem to be incompatible for now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, above comment starting with WARNING
is also not true since job twister-test-results
uses ubuntu-22.04
instead of self-hosted
. Am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now. Also, I have reworded the warning to be more concise.
f575314
to
998a599
Compare
Description
This PR implements changes required to migrate the workflow files and scripts from the
irnas-runners-software
repository to this one andirnas-workflows-software
. Some files got moved around and/or to different repositories, see Related below.Changes:
Closes #
Related https://github.com/IRNAS/irnas-runners-software/pull/6 IRNAS/irnas-workflows-software#9
Areas of interest for the reviewer
Check the workflow files and docs.
Checklist
functions.
I updated all customer-facing technical documentation.After-review steps