Skip to content

Commit

Permalink
fix: Parsing of west.yml when determening NCS version
Browse files Browse the repository at this point in the history
  • Loading branch information
TjazVracko committed Oct 2, 2024
1 parent 5542e64 commit 568f245
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]

### Fixed

- Parsing of `west.yml` when a project within the yaml does not contain the `repo-path` key.

## [0.23.0] - 2024-09-24

### Added
Expand Down
5 changes: 3 additions & 2 deletions src/east/helper_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,11 @@ def get_ncs_and_project_dir(west_dir_path: str) -> Tuple[str, str]:
try:
ncs = list(
filter(
lambda project: project["repo-path"] == "sdk-nrf", manifest["projects"]
lambda project: project.get("repo-path", "") == "sdk-nrf",
manifest["projects"],
)
)
except KeyError:
except KeyError as e:
# This can happen in the case where there is no sdk-nrf repo in the west yaml
# file, project is probably using ordinary Zephyr.
return None, project_path
Expand Down

0 comments on commit 568f245

Please sign in to comment.