IQSS/8533 - Temporary revert of title changes #8552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
changed the title
|
Closing in favor of reverting the whole tsv change for now (and a 5.101. release) and reapply that after #8533 is addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: It temporarily reverts changes to the citation block titles that cause a test failure due to #8533. The purpose of the PR is just to get something into the develop branch so that people who are up-to-date with that branch, i.e. in other PRs, won't have a test failure. (And anyone testing from development with the semantic apis could keep working.)
Which issue(s) this PR closes: It doesn't close anything, just a temporary fix
Closes #
Special notes for your reviewer: See #8533. With this commit, tests and any uses of the semantic APIs/ORE
export should be the same as in v5.10. Based on Tech Hour discussion,
I'll go ahead and implement a fix/change for #8533 in which I include
reverting this commit.
Suggestions on how to test this: Verify the IT tests pass, optionally check the json-ld migrate/create apis.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: