Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows" #10987

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Oct 30, 2024

I'm pretty sure we need to revert the following PR:

I'm seeing failures on both jobs affected.

For deploy_beta_testing at https://github.com/IQSS/dataverse/actions/runs/11600760387 for example it says "
Unable to download artifact(s): Artifact not found for name: built-app Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact. For more information, visit the GitHub Artifacts FAQ: https://github.com/actions/toolkit/blob/main/packages/artifact/docs/faq.md "

Screenshot 2024-10-30 at 5 02 31 PM

There's a similar error for the maven_unit_test job at https://github.com/IQSS/dataverse/actions/runs/11600879270

@pdurbin
Copy link
Member Author

pdurbin commented Oct 31, 2024

Just a heads up to @GPortas and others working on frontend GitHub actions... v3 is used there as well: https://github.com/search?q=repo%3AIQSS%2Fdataverse-frontend%20download-artifact&type=code

Screenshot 2024-10-31 at 10 33 19 AM

@pdurbin pdurbin requested a review from GPortas October 31, 2024 14:33
@pdurbin
Copy link
Member Author

pdurbin commented Oct 31, 2024

I created a new issue to try again to bump the version:

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reverts the prior PR

@stevenwinship stevenwinship self-assigned this Nov 1, 2024
@stevenwinship stevenwinship merged commit 90665f9 into develop Nov 1, 2024
1 of 2 checks passed
@stevenwinship stevenwinship deleted the revert-10822-dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7 branch November 1, 2024 17:18
@stevenwinship
Copy link
Contributor

Tested by rebasing another PR and the previously failing tests have now passed

@stevenwinship stevenwinship removed their assignment Nov 1, 2024
@pdurbin pdurbin added this to the 6.5 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06)
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

4 participants