Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get major version when deaccessioned #10974

Conversation

stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Oct 28, 2024

What this PR does / why we need it: Anonymous users are able to see files labeled as "Unpublished" in the search results on Dataverse, even though these files are actually published.

Which issue(s) this PR closes: #10947

Special notes for your reviewer:

Suggestions on how to test this:

  1. Deploy in a server like perf in order to have lots of data or locally and publish a dataset with version 1.0 with a file. Deaccession the dataset. Update the file and publish as 1.1
  2. Select "View All Data."
  3. Check the "Files" filter under the search filters.
  4. Under the "Publication Status" section, the "Unpublished" option will appear.
  5. Select the "Unpublished" filter option.
    This will result in the "Unpublished" label appearing, as seen in the provided screenshot, even though the files appear to be published when viewed individually.
  6. Check the versions to see that the major versions are deaccessioned and the latest file has a minor version
  7. Re-index the dataset curl http://localhost:8080/api/admin/index/dataset?persistentId=doi:10.7910/DVN/RCQXN1
  8. Re-load the "view All Data" page and see that the number of "Unpublished" files has decreased by the number of files in the dataset that was re-indexed
    Note: without this fix the number should remain the same

Does this PR introduce a user interface change? If mockups are available, please link/include them here:No

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Oct 28, 2024
@stevenwinship stevenwinship added FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) Type: Bug a defect Size: 10 A percentage of a sprint. 7 hours. labels Oct 28, 2024
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - consistent with the Slack discussion.

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Oct 28, 2024

This comment has been minimized.

1 similar comment

This comment has been minimized.

@stevenwinship
Copy link
Contributor Author

@pdurbin Could you give a quick review for the added release note?

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the release note makes sense but I'm suggesting a few tweaks.

@ofahimIQSS ofahimIQSS self-assigned this Oct 28, 2024

This comment has been minimized.

2 similar comments

This comment has been minimized.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10947-unpublished-files-appearing-in-search-results-for-anon-user
ghcr.io/gdcc/configbaker:10947-unpublished-files-appearing-in-search-results-for-anon-user

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ofahimIQSS
Copy link
Contributor

Testing Completed in Perf environment since test data couldn't be created in lower environments.
Testing of 10974.docx

@ofahimIQSS ofahimIQSS merged commit d18f01f into develop Oct 31, 2024
10 of 11 checks passed
@ofahimIQSS ofahimIQSS deleted the 10947-unpublished-files-appearing-in-search-results-for-anon-user branch October 31, 2024 15:18
@ofahimIQSS ofahimIQSS removed their assignment Oct 31, 2024
@pdurbin pdurbin added this to the 6.5 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

"Unpublished" Files Appearing in Search Results for Anonymous Users
4 participants