-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix get major version when deaccessioned #10974
fix get major version when deaccessioned #10974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - consistent with the Slack discussion.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
@pdurbin Could you give a quick review for the added release note? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the release note makes sense but I'm suggesting a few tweaks.
doc/release-notes/10947-unpublished-files-appearing-in-search-results-for-anon-user.md
Outdated
Show resolved
Hide resolved
doc/release-notes/10947-unpublished-files-appearing-in-search-results-for-anon-user.md
Show resolved
Hide resolved
doc/release-notes/10947-unpublished-files-appearing-in-search-results-for-anon-user.md
Show resolved
Hide resolved
…results-for-anon-user.md Co-authored-by: Philip Durbin <[email protected]>
…results-for-anon-user.md Co-authored-by: Philip Durbin <[email protected]>
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Testing Completed in Perf environment since test data couldn't be created in lower environments. |
What this PR does / why we need it: Anonymous users are able to see files labeled as "Unpublished" in the search results on Dataverse, even though these files are actually published.
Which issue(s) this PR closes: #10947
Special notes for your reviewer:
Suggestions on how to test this:
This will result in the "Unpublished" label appearing, as seen in the provided screenshot, even though the files appear to be published when viewed individually.
Note: without this fix the number should remain the same
Does this PR introduce a user interface change? If mockups are available, please link/include them here:No
Is there a release notes update needed for this change?: Included
Additional documentation: