Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCKER> unknown flag: --driver with M1 Mac #9771

Closed
pdurbin opened this issue Aug 10, 2023 · 15 comments · Fixed by #9779 or #10730
Closed

DOCKER> unknown flag: --driver with M1 Mac #9771

pdurbin opened this issue Aug 10, 2023 · 15 comments · Fixed by #9779 or #10730
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers.
Milestone

Comments

@pdurbin
Copy link
Member

pdurbin commented Aug 10, 2023

I'm opening this issue on behalf of @sekmiller who unfortunately is not having a great first time experience with Docker. 😅

He's using Docker 4.22.0 (117440). He's on an M1 Mac.

He's on the Payara 6 branch as of this commit: 0133009

When he tries to build the (Payara 6) base image with mvn -Pct -f modules/container-base install, he gets this:

[INFO] DOCKER> [gdcc/base:unstable] “base”: Created docker-build.tar in 3 seconds
[INFO] DOCKER> docker --config /Users/stephenkraffmiller/Documents/GitHub/modules/container-base/target/buildx-state buildx create --driver docker-container --name maven
[INFO] DOCKER> unknown flag: --driver

(This works for me on my M2 Mac at home.)

He also saw this on the Java 17 branch as of 7274eef

This GitHub issue stuck out for me:

@poikilotherm found this one:

Afterward, @sekmiller tried adding -Dfabric8-dmp.version=0.43.2 but it didn't help.

See also Slack discussion at https://iqss.slack.com/archives/C010LA04BCG/p1691592583014789

@pdurbin pdurbin added the Component: Containers Anything related to cloudy Dataverse, shipped in containers. label Aug 10, 2023
@pdurbin
Copy link
Member Author

pdurbin commented Aug 11, 2023

He also saw this on the Java 17 branch as of 7274eef

I just tried on my M2 Mac (same commit) and it worked fine. I wonder what the difference is. 🤔

I'm on Docker version 20.10.23, build 7155243

Docker Desktop version 4.17.0 (99724)

If it matters, macOS 13.4.1 (c) (22F770820d)

@poikilotherm
Copy link
Contributor

@sekmiller @pdurbin y'all could try https://github.com/fabric8io/docker-maven-plugin/releases/tag/v0.43.3 via -Dfabric8-dmp.version=0.43.3. They might have just added a workaround.

@pdurbin
Copy link
Member Author

pdurbin commented Aug 14, 2023

poikilotherm added a commit that referenced this issue Aug 14, 2023
With this new version, a problem on M1 MACs not being able to build
with Docker because of a non-existing config file was worked around
by the DMP devs.

See also: fabric8io/docker-maven-plugin#1678
@poikilotherm
Copy link
Contributor

While 0.43.3 fixed the problem on @sekmiller 's M1, it causes failure when pushing preview images to GHCR.

Opened a bug report at DMP's fabric8io/docker-maven-plugin#1701

pdurbin pushed a commit that referenced this issue Sep 26, 2023
With this new version, a problem on M1 MACs not being able to build
with Docker because of a non-existing config file was worked around
by the DMP devs.

See also: fabric8io/docker-maven-plugin#1678
@pdurbin pdurbin added this to the 6.1 milestone Sep 28, 2023
@wanieldilson
Copy link

This seems fixed in 0.43.3 but broken again in 0.43.4

@pdurbin
Copy link
Member Author

pdurbin commented Nov 30, 2023

I'm seeing this problem on my non-M1 Mac (Intel chip, that is). I'm using 0.43.4 (develop branch, 960751f). I started this thread about it:

https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/unknown.20flag.3A.20--driver/near/404949182

@pdurbin
Copy link
Member Author

pdurbin commented Nov 30, 2023

mvn -Pct -f modules/container-base install -Dfabric8-dmp.version=0.43.3 worked! Interesting.

@grnadav
Copy link

grnadav commented Feb 19, 2024

I'm getting this issue on my non-M1 mac (and NOT getting it on M1), @pdurbin 's proposal did not work for me.
using version 0.43.4

@pdurbin
Copy link
Member Author

pdurbin commented Feb 22, 2024

@grnadav hmm, maybe try downgrading to 0.43.3?

@grnadav
Copy link

grnadav commented Feb 27, 2024

Yes, it didn't work.
My current workaround is to add -Ddocker.platforms= when running on my Intel machine to disable buildx

@pdurbin
Copy link
Member Author

pdurbin commented Feb 27, 2024

@grnadav it's funny, I'm on an M2 at home and I haven't had any trouble lately. I just added it to our agenda for Thursday.

I don't love having lots of back and forth on closed issues. Do you want to move to https://dataverse.zulipchat.com/#narrow/stream/375812-containers/topic/unknown.20flag.3A.20--driver/near/404949182 or a new thread?

@pdurbin
Copy link
Member Author

pdurbin commented Feb 29, 2024

@grnadav I heard 0.44 is out. Would you like to try it? 😄

@poikilotherm
Copy link
Contributor

Trying it out is easy: just go for mvn -Pct -f modules/container-base install -Dfabric8-dmp.version=0.44

@grnadav
Copy link

grnadav commented Feb 29, 2024

Oh nice, didn't notice the release (I'll subscribe for future).
I'll give it a try and update

pdurbin added a commit that referenced this issue Jul 25, 2024
This reverts commit 146c927.

We can't use 0.44 because of this error:

"Unable to inspect image [solr:]"

See https://github.com/fabric8io/docker-maven-plugin/issues/1756e
pdurbin added a commit that referenced this issue Jul 29, 2024
lower versions don't work on Mac
@pdurbin
Copy link
Member Author

pdurbin commented Jul 29, 2024

I'm reopening this issue.

We ended up staying on 0.43.4.

We tried 0.44.0 but it didn't work on Mac.

I just tried 0.45.0 (released two days ago) and it seems to work. I'm making a pull request to upgrade to it.

@pdurbin pdurbin reopened this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers.
Projects
None yet
4 participants