Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Spreadsheet previewer #6256

Closed
4tikhonov opened this issue Oct 4, 2019 · 11 comments · Fixed by #6571
Closed

New Spreadsheet previewer #6256

4tikhonov opened this issue Oct 4, 2019 · 11 comments · Fixed by #6571

Comments

@4tikhonov
Copy link
Contributor

We're working on the Spreadsheet and other previewers in DataverseEU SSHOC project.
New CSV viewer was developed by @anncie-pcss from Poznan Supercomputing & Networking Center (Poland) and already available for the public.

After the discussion with @qqmyers we've agreed that it can be good idea to keep all previewers in one place so this previewer has been merged in QDR repository

Can you please test it and add CVS previewer to the list of tools?

@pdurbin
Copy link
Member

pdurbin commented Oct 4, 2019

@4tikhonov I just tried in on my server at https://dev2.dataverse.org and it's so beautify I want to cry! Thank you!

Screenshots below.

Screen Shot 2019-10-04 at 6 03 56 PM
Screen Shot 2019-10-04 at 6 04 05 PM

@pdurbin
Copy link
Member

pdurbin commented Oct 4, 2019

I want this in Harvard Dataverse so I opened IQSS/dataverse.harvard.edu#38 😄

@stevenmce
Copy link

HI Everyone,

This is a great addition - looks great.
There's a particularly interesting element to this in terms of how to then incorporate the metadata from the DDI - so you can actually find out what the columns mean.

(I'd be particularly interested in how this could link to W3C's CSV on the Web work - see https://www.w3.org/TR/tabular-data-primer/#documentation-columns)

BBBBBUUUTTTT - note that it has some major confidentiality implications as well.

@mdmADA @scolapasta I'd be concerned about previewing the data without suitable permissions??

Cheers,
Steve

@qqmyers
Copy link
Member

qqmyers commented Oct 5, 2019

FWIW: All of the previewers respect Dataverse's access controls. For restricted files, if you would have the ability to download the file in Dataverse, you'll be able to see the preview (the previewer code in your browser gets a copy of your 'api key' from Dataverse when launched, which allows it to retrieve the file for viewing.) If that's insufficient, site admins can configure previewers to only work on public files.

@jggautier
Copy link
Contributor

jggautier commented Oct 7, 2019 via email

@qqmyers
Copy link
Member

qqmyers commented Oct 7, 2019

I believe they do.

@djbrooke
Copy link
Contributor

djbrooke commented Oct 9, 2019

Thanks @4tikhonov @anncie-pcss for the contribution and @qqmyers for giving the previewer a home. :) We look forward to adding this previewer (once preview mode is available) into dataverse.harvard.edu.

Do y'all think that CSV previewer is the appropriate name for this? I saw it supports contenttype tsv and csv based on the last few lines of https://github.com/QualitativeDataRepository/dataverse-previewers/blob/master/README.md but it appears to leverage the ingest functionality to be available for other types as well.

@4tikhonov
Copy link
Contributor Author

Hi @djbrooke, it's Spreadsheet previewer indeed, we're moving forward with the development according to our strategy.
Screen Shot 2019-10-09 at 11 19 26 AM

@qqmyers
Copy link
Member

qqmyers commented Oct 15, 2019

FYI: The 'CSV' previewer has been renamed as the 'Spreadsheet' previewer. Since the change is to the filename as well as the display, its necessary to reinstall the tool/update the db with the new name. The Readme file in github has been updated to show the new curl commands. (It would be possible to keep a second copy with the old name to be backward compatible, but I'm hoping its easy enough for people to switch this early - if not, let me know).

@pdurbin pdurbin changed the title New CSV previewer New Spreadsheet previewer Oct 15, 2019
@pdurbin
Copy link
Member

pdurbin commented Oct 15, 2019

@qqmyers thanks for the heads up. I updated the title of this issue.

The next step is for you or @4tikhonov to @anncie-pcss to update the "File Previewers" row in https://github.com/IQSS/dataverse/blob/develop/doc/sphinx-guides/source/_static/admin/dataverse-external-tools.tsv to mention the new tool. Then I think we can close this issue. Should we give the honor to @anncie-pcss ? It's a great tool! 😄

@4tikhonov
Copy link
Contributor Author

Hi @pdurbin and @qqmyers, please go ahead. And of course credits should go to @anncie-pcss and SSHOC Dataverse project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants