Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Download URL for Public Files #3584

Closed
djbrooke opened this issue Jan 20, 2017 · 13 comments
Closed

Provide Download URL for Public Files #3584

djbrooke opened this issue Jan 20, 2017 · 13 comments
Assignees
@kcondon
Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Milestone
4.6.1 - ORCID and...

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Jan 20, 2017 •
edited by kcondon
Loading

If a file has no Terms of Use and there is no guestbook associated with the dataverse, provide a download URL on the file page.
@djbrooke djbrooke added the ready label Jan 20, 2017
@pdurbin
Copy link
Member

pdurbin commented Jan 20, 2017

This issue reminds me a lot of #2416.

@djbrooke
Copy link
Contributor Author

Some tasks coming out of our sprint planning meeting today:

  • Determine where this link will appear
  • On those files where it is not available, some information should be provided to the user about why it's not there.

@pdurbin pdurbin self-assigned this Jan 30, 2017
@pdurbin pdurbin added in progress and removed ready labels Jan 30, 2017
pdurbin added a commit that referenced this issue Jan 31, 2017
@pdurbin
show URL on dataset landing page #3584
a1ebe6e 
Refactor `isDownloadPopupRequired` and `callDownloadServlet` to make
them testable.

Tested from the GUI:

- Yes popup and no URL if Terms of Use is set.
- Yes popup and no URL if guestbook.
- No download button and no URL if Terms of Access is set.
- No download button and no URL if file restricted.
- No popup and yes URL given defaults (CC0, etc.)
- No popup and yes URL when Terms of Use is set and license is CC0. Bug.

Questions:

- Is the the bug identified above valid?
- What about tabular files? Which URL should be shown?
@pdurbin pdurbin mentioned this issue Jan 31, 2017
Merged
11 tasks
@pdurbin
Copy link
Member

pdurbin commented Jan 31, 2017

I created pull request #3608 and put it in Code Review at https://waffle.io/IQSS/dataverse

I believe there's an existing bug with the download popu but it's tricky to pull off in the GUI. Here's how:

  • Set waiver to non-CC0
  • Fill in Terms of Use
  • Save Changes
  • Click "Edit Terms Requirements" again.
  • Change waiver to CC0.
  • The Terms of Use are still in the database so they should be respected, perhaps. However, no popup is shown. Perhaps in the case above the Terms of Use should be deleted from the database after the user confirms this is the desire.

Anyway, I found this because the the logic to show the file download URL or not piggybacks off the logic to show the pop or not. @sekmiller and I agreed on this approach. I also wrote a lot of tests. 😄

Below are some screenshots of how it looks as of a1ebe6e if @mheppler would like to jump in.

screen shot 2017-01-31 at 1 48 03 pm
screen shot 2017-01-31 at 1 47 52 pm

@pdurbin pdurbin added the UX & UI: Design This issue needs input on the design of the UI and from the product owner label Jan 31, 2017
@pdurbin pdurbin removed their assignment Jan 31, 2017
@mheppler
Copy link
Contributor

Yes, I will need to address the UI for this feature. Please do not move it to QA until I have had that chance.

@scolapasta scolapasta self-assigned this Jan 31, 2017
@pdurbin pdurbin assigned mheppler and unassigned mheppler Jan 31, 2017
@pdurbin
Copy link
Member

pdurbin commented Feb 1, 2017

Oh, one wrinkle I'd like to bring up is that tabular files that have gone through ingest actually have multiple download formats. You can see this in the screenshot below (original vs. tab-delimited vs. RData) or on this live server where I deployed the code: https://dev1.dataverse.org/file.xhtml?fileId=377&version=1.1

Are we fine with just showing the one link under "Download URL" for tabular files?

50by1000 tab_-tabular_dataverse-_2017-02-01_10 08 57

@djbrooke
Copy link
Contributor Author

djbrooke commented Feb 1, 2017

Let's provide only the .tab download for now.

@sekmiller
Copy link
Contributor

I would point out that the multiple download types and the detour into guestbook are the main reasons we didn't just put the download url into the page in the first place.

@djbrooke
Copy link
Contributor Author

djbrooke commented Feb 1, 2017

Note that this issue is only for files without TOU and Guestbook.

mheppler added a commit that referenced this issue Feb 1, 2017
@mheppler
Moved Download URL into the File Metadata tab for a consistent displa…
f8dbcaa 
…y compared to other fields like Dataset Persistent ID. [ref #3584]
@mheppler mheppler assigned scolapasta and unassigned mheppler and scolapasta Feb 1, 2017
pdurbin added a commit that referenced this issue Feb 6, 2017
@pdurbin
Merge branch 'develop' into 3584-public-file-url #3584
11be4dd
pdurbin added a commit that referenced this issue Feb 6, 2017
@pdurbin
versionState should never be null #3584
c65a0df
pdurbin added a commit that referenced this issue Feb 6, 2017
@pdurbin
improve code coverage a bit #3584
279e2bd
@pdurbin
Copy link
Member

pdurbin commented Feb 6, 2017

@scolapasta here are the changes you requested:

Anything else before we move this issue to QA?

@scolapasta scolapasta assigned pdurbin and unassigned scolapasta and pdurbin Feb 6, 2017
@pdurbin pdurbin mentioned this issue Feb 6, 2017
Closed
@kcondon
Copy link
Contributor

kcondon commented Feb 6, 2017

I'm not seeing the download urls for public files, no guestbook.

@kcondon kcondon self-assigned this Feb 6, 2017
@pdurbin
Copy link
Member

pdurbin commented Feb 7, 2017 •
edited
Loading

@kcondon it work on my machine. 😄 I just tried it again. I'm probably not understanding what the bug is. I'll probably need a demo.

screen shot 2017-02-07 at 9 18 27 am

@kcondon
Copy link
Contributor

kcondon commented Feb 7, 2017 •
edited
Loading

Link appears in draft then disappears in published version due to following popup rule as proxy for biz rules. Popups do not appear by design in Draft however.

Link does remain in published version for the public case intended.

Download counts are not incremented and guestbook response not updated using download link per this administratively closed issue: #3331

pdurbin added a commit that referenced this issue Feb 7, 2017
@pdurbin
add todo for disappearing Download URL scenario #3584
ed8e8b5
kcondon added a commit that referenced this issue Feb 7, 2017
@kcondon
Merge pull request #3608 from IQSS/3584-public-file-url
2e61c01 
show URL for file on file landing page #3584
@pdurbin
Copy link
Member

pdurbin commented Feb 7, 2017

Link appears in draft then disappears in published version due to following popup rule as proxy for biz rules. Popups do not appear by design in Draft however.

Good catch. I added a todo in the code for the "disappearing Download URL" scenario described above: ed8e8b5

@kcondon kcondon closed this as completed Feb 7, 2017
@kcondon kcondon removed the Status: QA label Feb 7, 2017
@pdurbin pdurbin mentioned this issue May 2, 2017
Closed
@pdurbin pdurbin mentioned this issue Dec 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcondon kcondon

Labels
UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Milestone
4.6.1 - ORCID and File Replace
Development

No branches or pull requests
6 participants
@pdurbin @mheppler @sekmiller @scolapasta @kcondon @djbrooke