Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets - File Page #3578

Closed
djbrooke opened this issue Jan 18, 2017 · 4 comments
Closed

Widgets - File Page #3578

djbrooke opened this issue Jan 18, 2017 · 4 comments
Assignees
Labels
Type: Suggestion an idea UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@djbrooke
Copy link
Contributor

djbrooke commented Jan 18, 2017

Navigating to a file page while in the context of a widget removes you from that widget and takes you a full-screen version of the dataverse.

Follow these steps:

  • Go to http://gking.harvard.edu/data
  • Click into a dataset (note that you remain in the widget iframe)
  • Click into one of the files for the dataset (you leave the widget iframe and are directed to the dataverse)

Instead, the navigation to a file page should stay within the iframe, similar to how the dataverse to dataset navigation works.

@djbrooke djbrooke added ready and removed ready labels Jan 18, 2017
@djbrooke djbrooke modified the milestone: 4.6.3 - Tabular Mapping Jan 27, 2017
@djbrooke djbrooke added the ready label Jan 31, 2017
@djbrooke djbrooke removed the ready label Feb 8, 2017
@pdurbin pdurbin added Type: Suggestion an idea UX & UI: Design This issue needs input on the design of the UI and from the product owner labels Jun 8, 2017
@mheppler mheppler changed the title Widgetize File Page Widgets - File Page Jun 15, 2017
@mheppler
Copy link
Contributor

mheppler commented Jun 16, 2017

Scope Outline:

  • navigate from dataset pg to file pg in widget
  • hide metrics block, edit button, edit metadata button, map data button on file pg in widget
  • hide map data button on dataset pg in widget
  • returned export metadata button back to dataset pg in widget

Additional Scope Features:

Not In Scope:

@oscardssmith
Copy link
Contributor

Unassigned myself, as I don't really know how xhtml works well enough to tell if these changes are reasonable.

@pdurbin
Copy link
Member

pdurbin commented Jun 22, 2017

I took a look at pull request #3922 as of ed2c5ef and the changes seem reasonable to me. Here's the comment I left in my review:

These changes make sense to me. Approved. I didn't actually run the code myself. Now that the Dev Guide includes information on getting set up to hack on the code for remote accounts (Shibboleth and OAuth) as well as Geoconnect, it might be nice to someday add a little information on how to hack on widgets code.

With permission by @mheppler I just merged the latest from "develop" into the pull request. Moving to QA in https://waffle.io/IQSS/dataverse

@pdurbin
Copy link
Member

pdurbin commented Jun 22, 2017

I just did a quick test as of a461340 and it looks ok, like this:

screen shot 2017-06-22 at 4 20 44 pm

Here's my "website":

murphy:deleteme pdurbin$ cat index.html 
BEGIN
<script src="https://dev1.dataverse.org/resources/js/widgets.js?alias=spruce&amp;dvUrl=https://dev1.dataverse.org&amp;widgetScope=spruce&amp;widget=iframe&amp;heightPx=500"></script>
END
murphy:deleteme pdurbin$ 

@kcondon kcondon self-assigned this Jun 26, 2017
@kcondon kcondon closed this as completed Jun 26, 2017
@djbrooke djbrooke added this to the 4.7.1 - Dashboard milestone Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Suggestion an idea UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants