Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create customCAFEAdditionalData metadata block with CCH Terms field #318

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Saixel
Copy link

@Saixel Saixel commented Oct 24, 2024

What this PR does / why we need it:

This PR creates a new custom metadatablock customCAFEAdditionalData, which includes the CCH Terms field.

Which issue(s) this PR closes:

Additional documentation:

Captura de pantalla 2024-10-24 a las 19 12 32
Captura de pantalla 2024-10-24 a las 19 13 28

@Saixel Saixel added NIH CAFE Issues associated with the NIH CAFE project FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) labels Oct 24, 2024
@Saixel Saixel assigned Saixel and unassigned Saixel Oct 24, 2024
@Saixel Saixel requested a review from jggautier October 25, 2024 09:24
@jggautier
Copy link
Collaborator

Hi @Saixel. I looked at the screenshots and the TSV file. From that, the only change I'd suggest is adding a description of the field in the TSV file's "description" column so that something appears when folks hover over or click on the blue question mark next to the CCH Term field label. There's more guidance about the Dataverse metadata text guidelines about tooltips.

@Saixel Saixel mentioned this pull request Nov 5, 2024
16 tasks
@cmbz cmbz added the FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) label Nov 7, 2024
@cmbz cmbz added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 21, 2024
@jggautier
Copy link
Collaborator

jggautier commented Nov 26, 2024

Thanks for adding the description for the field's tooltip. The only thing I think needs to be changed is the period at the end of the sentence. Could you delete the period? Or would you mind if I deleted it?

Removed the period at the end of the field's description (tooltip) to follow the metadata text guidelines
Copy link
Collaborator

@jggautier jggautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Saixel. After our conversation on Slack I deleted the period at the end of the description.

@Saixel Saixel removed their assignment Dec 4, 2024
@cmbz cmbz added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) NIH CAFE Issues associated with the NIH CAFE project
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Implement Dropdown Selector for NIH Controlled Vocabulary in Keywords
3 participants