Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unit and integration tests from pre-commit hook #557

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ekraffmiller
Copy link
Contributor

What this PR does / why we need it:

Remove unit and integration tests from the pre-commit hook so that commits don't take as long

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Review the code change and optionally do a local commit

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

@ekraffmiller ekraffmiller marked this pull request as ready for review December 3, 2024 16:24
@ekraffmiller ekraffmiller added SPA.Q4.10 Resolve TODOs and tech debt GREI Re-arch GREI re-architecture-related FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Dec 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 97.363% (+0.02%) from 97.345%
when pulling fb4e846 on feat/556-simplify-pre-commit-hook
into 02b04e5 on develop.

@g-saracca g-saracca self-assigned this Dec 4, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Approving

@g-saracca g-saracca removed their assignment Dec 4, 2024
@ofahimIQSS ofahimIQSS self-assigned this Dec 4, 2024
@cmbz cmbz added the FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA.Q4.10 Resolve TODOs and tech debt
Projects
Status: QA ✅
Development

Successfully merging this pull request may close these issues.

Update pre-commit hook so it is less time consuming
5 participants