Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Collection and Share Dataset features #554

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

g-saracca
Copy link
Contributor

What this PR does / why we need it:

Replicates the Share feature on the Collection Page and Dataset Page, supporting the same sharing channel options as in JSF.
Same modal component SocialShareModal it's used for both pages.

Which issue(s) this PR closes:

Suggestions on how to test this:

Click the share buttons and check that the redirections are correct.
Unlike the JSF version, the links do not open in a popup but open in a new tab.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes.
Collection Page
Screen Shot 2024-11-21 at 14 43 15

Dataset Page
Screen Shot 2024-11-21 at 14 43 28
Screen Shot 2024-11-21 at 14 43 36

Is there a release notes update needed for this change?:

No

Additional documentation:

No

@g-saracca g-saracca added Size: 3 A percentage of a sprint. 2.1 hours. SPA: Dataset page (View) SPA: Collection Page GREI Re-arch GREI re-architecture-related Original size: 3 SPA.Q4.8 Collection Page: Share FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) labels Nov 21, 2024
@coveralls
Copy link

coveralls commented Nov 21, 2024

Coverage Status

coverage: 97.376% (+0.03%) from 97.345%
when pulling bcc0628 on feat/553-collection-page-share
into 88d218a on develop.

@g-saracca g-saracca marked this pull request as ready for review November 21, 2024 18:52
@g-saracca
Copy link
Contributor Author

@pdurbin as promised, here is the link to the SocialShareModal component storybook.

@pdurbin
Copy link
Member

pdurbin commented Nov 21, 2024

@g-saracca looks good to me! Modern icons!

@ChengShi-1 ChengShi-1 self-assigned this Nov 22, 2024
@ChengShi-1 ChengShi-1 self-requested a review November 22, 2024 13:27
Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job~ I left some comments here may need changes.

@g-saracca
Copy link
Contributor Author

@ChengShi-1 all the requested changes have been addressed 👍🏼 , thanks!

Copy link
Contributor

@ChengShi-1 ChengShi-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Approve

@ofahimIQSS ofahimIQSS assigned ofahimIQSS and unassigned ofahimIQSS Nov 26, 2024
@ofahimIQSS ofahimIQSS self-assigned this Dec 4, 2024
@cmbz cmbz added FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) FY25 Sprint 12 FY25 Sprint 12 (2024-12-04 - 2024-12-18) GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page SPA: Dataset page (View) SPA.Q4.8 Collection Page: Share
Projects
Status: QA ✅
Development

Successfully merging this pull request may close these issues.

Share Collection and Share Dataset features
6 participants