-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/528 Use fields from parent - Create Collection form behavior #540
Fix/528 Use fields from parent - Create Collection form behavior #540
Conversation
This change is causing an error in Create Dataset, when the parent collection is not the Root. We need a fix in the Dataverse API to get the correct metadata fields for the Create Dataset form. Added a waiting tag to this issue. createDatasetTest.mov |
@ekraffmiller working great on my end after pulling new unstable dataverse image. Screen.Recording.2024-11-05.at.14.49.43.mov |
Working for me now too, needed to get the newest image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, approving 👍
No issues found during testing. Merging PR. |
What this PR does / why we need it:
In the Create Collection form, when the user checks the “Use fields from [parent]” checkbox, we are now sending metadata block names and input levels as undefined to the js-dataverse use case.
This was tested also using the GHCR container image generated from IQSS/dataverse#10985 PR and it works great.
This comment from @pdurbin explains what this is fixing very well.
Which issue(s) this PR closes:
Suggestions on how to test this:
Step 1: Run the Development Environment
npm i
.cd packages/design-system && npm i && npm run build
.cd ../../
..env
file similar to.env.example
, with the variableVITE_DATAVERSE_BACKEND_URL=http://localhost:8000
.cd dev-env
../run-env.sh unstable
.Step 2: Test the fix
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
No
Additional documentation:
No