-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File upload: alert when a file could not be added for upload #478
base: develop
Are you sure you want to change the base?
File upload: alert when a file could not be added for upload #478
Conversation
Hi @ErykKul, after discussing with the team we thought it was a good idea to discuss about this behavior change with the rest of the team. |
After some feedback, this one needs more work before it is ready for review -> status changed to in progress. |
2024/09/25: Moving back to SPA backlog for further work. |
What this PR does / why we need it:
With each upload, all files need to have a unique combination of the label (directory) and the file name. Until now, when adding the same file (as already present in the list of files to be added at the bottom of the file upload page), it is silently ignored and is not uploaded. This PR adds an alert on the top of the page when this happens to notify the user that the file could not be added.
Note that you can still add the same file multiple times to the dataset by uploading them one by one. The upload page does not check the file names of the files already present in the dataset. When the same file is uploaded again, it is handled in the standard way by the Dataverse API and gets the "-1" suffix, e.g., after adding "test.json" twice, you will have two files in the dataset: "test.json" and "test-1.json".
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Add the same file for upload twice, when adding second time (and the previously added files is still in the list of the files to be added at the bottom of the upload page), an alert should be shown (and the file is not added second time).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: