add new pid settings, switch format #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need new PID settings now that IQSS/dataverse#10234 has been merged. Upstream we add them as JVM_ARGS so let's use the same format. We can perhaps switch to MPCONFIG-only once we're sure it works fine.
MellyGray
approved these changes
Mar 11, 2024
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
add new pid settings, switch format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need new PID settings now that...
... has been merged.
Upstream we add them as JVM_ARGS so let's use the same format.
We can perhaps switch to MPCONFIG-only once we're sure it works fine.