Refactor extract File Metadata to its own model #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
264 - Add the AccessFileMenu to File Page
MellyGray
added
Size: 3
Base automatically changed from
feature/263-add-filemetadata-section-to-the-file-page
to
develop
February 1, 2024 12:18
ekraffmiller
reviewed
Feb 5, 2024
ekraffmiller
approved these changes
Feb 5, 2024
GPortas
approved these changes
Feb 8, 2024
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
Refactor extract File Metadata to its own model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a refactor to separate file metadata into its own model. This change is necessary to enable the reuse of file metadata in both the File model and the FilePreview model
Special notes for your reviewer:
I didn't add this PR to the sprint board because I think that this PR is part of the other PR #281. I've just split the PR to facilitate the code review, but once both PRs are reviewed we can merge this one into #281 to QA them together. Let me know if that makes sense
Suggestions on how to test this:
Run boh unit and e2e tests and check that everything works as usual
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no