Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

262 - File labels section of the File page #271

Conversation

MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Dec 22, 2023

What this PR does / why we need it:

This PR adds the file labels section of the File Page UI.

This includes:

  1. Same Dataset labels as in the Dataset Page
  2. Restricted icon if the file is restricted

Which issue(s) this PR closes:

Special notes for your reviewer:

I refactored the Restricted icon we were using in the files table from the Dataset page to be able to rehuse it the in the File Page.

Suggestions on how to test this:

  1. Install the necessary dependencies using npm install.
  2. Build the design system with cd packages/design-system && npm run build.
  3. Navigate back to the root directory with cd ../../.
  4. Start Storybook with npm run storybook.
  5. Visit the File Page in the Storybook
    9 Visit the File Page Restricted in the Storybook
  6. Visit the File Page Restricted With Access Granted in the Storybook

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Captura de pantalla 2023-12-14 a las 11 33 58

Is there a release notes update needed for this change?:

No

Additional documentation:

@MellyGray MellyGray added the Size: 3 A percentage of a sprint. 2.1 hours. label Dec 22, 2023
@MellyGray MellyGray marked this pull request as ready for review December 22, 2023 17:16
@coveralls
Copy link

Coverage Status

coverage: 97.854% (-0.002%) from 97.856%
when pulling 9b1c321 on feature/262-file-labels-section-of-the-file-page
into 8665490 on feature/249-boilerplate-file-page.

@GPortas GPortas self-assigned this Jan 2, 2024
@GPortas GPortas added UI Tasks related to the user interface (UI) or frontend development pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows labels Jan 2, 2024
@GPortas GPortas assigned MellyGray and GPortas and unassigned GPortas Jan 4, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add. Looks good to me!

files1

files2

files3

@ekraffmiller ekraffmiller self-assigned this Jan 8, 2024
@ekraffmiller
Copy link
Contributor

Looks good!

@ekraffmiller ekraffmiller merged commit b5f65e2 into feature/249-boilerplate-file-page Jan 8, 2024
11 of 14 checks passed
@MellyGray MellyGray deleted the feature/262-file-labels-section-of-the-file-page branch February 1, 2024 14:13
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…-of-the-file-page

262 - File labels section of the File page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. UI Tasks related to the user interface (UI) or frontend development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants