-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
262 - File labels section of the File page #271
Merged
ekraffmiller
merged 3 commits into
feature/249-boilerplate-file-page
from
feature/262-file-labels-section-of-the-file-page
Jan 8, 2024
Merged
262 - File labels section of the File page #271
ekraffmiller
merged 3 commits into
feature/249-boilerplate-file-page
from
feature/262-file-labels-section-of-the-file-page
Jan 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPortas
added
UI
Tasks related to the user interface (UI) or frontend development
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
labels
Jan 2, 2024
GPortas
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! |
ekraffmiller
merged commit Jan 8, 2024
b5f65e2
into
feature/249-boilerplate-file-page
11 of 14 checks passed
MellyGray
deleted the
feature/262-file-labels-section-of-the-file-page
branch
February 1, 2024 14:13
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
…-of-the-file-page 262 - File labels section of the File page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pm.GREI-d-2.7.1
NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows
pm.GREI-d-2.7.2
NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows
Size: 3
A percentage of a sprint. 2.1 hours.
UI
Tasks related to the user interface (UI) or frontend development
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the file labels section of the File Page UI.
This includes:
Which issue(s) this PR closes:
Special notes for your reviewer:
I refactored the Restricted icon we were using in the files table from the Dataset page to be able to rehuse it the in the File Page.
Suggestions on how to test this:
npm install
.cd packages/design-system && npm run build
.cd ../../
.npm run storybook
.9 Visit the File Page Restricted in the Storybook
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
No
Additional documentation: