Merge pull request #543 from IQSS/535-implement-the-getdatasetcitatio…

…n-once-it-includes-deaccessioned-datasets Remove the skip from e2e test for getByPersistentId, so the test case could be included
IQSS · Nov 8, 2024 · 0a25d00 · 0a25d00
2 parents 64b8367 + 159058a
commit 0a25d00
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/sections/dataset/dataset-action-buttons/link-dataset-button/LinkDatasetButton.tsx b/src/sections/dataset/dataset-action-buttons/link-dataset-button/LinkDatasetButton.tsx
@@ -12,7 +12,6 @@ export function LinkDatasetButton({ dataset }: LinkDatasetButtonProps) {
   const { t } = useTranslation('dataset')
   const { user } = useSession()
   const handleClick = () => {
-    // TODO - Implement upload files
     showModal()
   }
   const { showModal } = useNotImplementedModal()

diff --git a/tests/e2e-integration/integration/datasets/DatasetJSDataverseRepository.spec.ts b/tests/e2e-integration/integration/datasets/DatasetJSDataverseRepository.spec.ts
@@ -322,8 +322,7 @@ describe('Dataset JSDataverse Repository', () => {
     })
   })
 
-  it.skip('gets the dataset by persistentId when the dataset is deaccessioned', async () => {
-    // TODO - Implement once the getDatasetCitation includes deaccessioned datasets
+  it('gets the dataset by persistentId when the dataset is deaccessioned', async () => {
     const datasetResponse = await DatasetHelper.create(collectionId)
 
     await DatasetHelper.publish(datasetResponse.persistentId)
@@ -337,8 +336,10 @@ describe('Dataset JSDataverse Repository', () => {
       const datasetExpected = datasetData(dataset.persistentId, dataset.version.id)
 
       expect(dataset.version.title).to.deep.equal(datasetExpected.title)
+      expect(dataset.version.publishingStatus).to.equal(DatasetPublishingStatus.DEACCESSIONED)
     })
   })
+
   it('gets the dataset by persistentId when is locked', async () => {
     const datasetResponse = await DatasetHelper.create(collectionId)
     await DatasetHelper.lock(datasetResponse.id, DatasetLockReason.FINALIZE_PUBLICATION)