Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create/destroy datasets on each IT/functional run #143

Merged
merged 14 commits into from
Apr 22, 2024
Merged

Create/destroy datasets on each IT/functional run #143

merged 14 commits into from
Apr 22, 2024

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Apr 9, 2024 •
edited
Loading

What this PR does / why we need it:

This PR adds the creation and deletion of datasets and collections in functional and integration tests. Each test file independently manages the creation and deletion of collections and datasets, thus avoiding dependencies between test files and race condition issues.

Which issue(s) this PR closes:

Suggestions on how to test this:

Visual inspection of the code and GitHub actions.

@GPortas GPortas marked this pull request as ready for review April 10, 2024 10:09
@GPortas GPortas added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. labels Apr 10, 2024
@MellyGray MellyGray self-assigned this Apr 11, 2024
MellyGray
MellyGray requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I hope this will fix the race condition

test/testHelpers/collections/collectionHelper.ts Outdated Show resolved Hide resolved
test/integration/collections/CollectionsRepository.test.ts Outdated Show resolved Hide resolved
test/integration/datasets/DatasetsRepository.test.ts Outdated Show resolved Hide resolved
test/integration/datasets/DatasetsRepository.test.ts Outdated Show resolved Hide resolved
@MellyGray MellyGray assigned GPortas and unassigned MellyGray Apr 15, 2024
@GPortas GPortas requested a review from MellyGray April 19, 2024 15:38
@GPortas GPortas assigned MellyGray and unassigned GPortas Apr 19, 2024
@GPortas
Copy link
Contributor Author

GPortas commented Apr 19, 2024

Thanks for your review. Great suggestions.

MellyGray
MellyGray approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MellyGray MellyGray removed their assignment Apr 22, 2024
@g-saracca g-saracca self-assigned this Apr 22, 2024
@g-saracca
Copy link
Contributor

All Github actions look good!

@g-saracca g-saracca merged commit 33a3760 into develop Apr 22, 2024
5 checks passed
@g-saracca g-saracca deleted the 138-dataset-cleanup-before-after-functional-and-it-run branch April 22, 2024 15:14
@cmbz cmbz mentioned this pull request May 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MellyGray MellyGray MellyGray approved these changes

Assignees

@g-saracca g-saracca

Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create and destroy test datasets on each integration/functional test run
3 participants
@GPortas @g-saracca @MellyGray