Streamlined code & added workshop attachment feature #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Streamlining => remove redundant code & clear up project structure. Removed some unused imports & more with the help of `cargo fix`.
Some build errors were left untouched by `cargo fix`. Unused but valid code will be marked by `#[allow(dead_code)]`.
Last commit mentions build errors but build warning were meant.
Should make project structure a bit cleaner. Also, the db models module re-exports the models from the initial schema.rs definition.
Should make project structure a bit cleaner. Also prefixed all structs with `Route` to distinguish them from `db` models better.
Added field to Route's NewWorkshop struct for attachments. When no attachments are given, default value (empty vector) will be used.
When creating workshops one can now pass attachments to it. TODO: * Adapt update & delete workshop to use attachments * Update docs * Update postman collection
When updating workshops one can now pass attachments to it. Workshop delete does not need any modifications because "workshopattachments" table cascades values when a workshop is deleted. Also fixed problem that "workshopattachments" table was not cleared when using `db_clear = true` in `Rocket.toml`. TODO: * Update docs * Update postman collection
|
Rocket fails to build on latest nightly, see issue 89935 from https://github.com/rust-lang/rust/issues/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.