Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mwrap): remove mwrap, add cyclonev wrapper #96

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

P-Miranda
Copy link
Contributor

  • remote unnecessary memory wrapper for iob_soc_opencryptolinux. iob_soc_opencryptolinux does not have int_mem module, therefore does not need memory wrapper like iob_soc
  • add custom cyclonev fpga wrapper to not use iob_soc fpga wrapper that uses mwrap instance

- remote unnecessary memory wrapper for iob_soc_opencryptolinux.
  iob_soc_opencryptolinux does not have int_mem module, therefore does
  not need memory wrapper like iob_soc
- add custom cyclonev fpga wrapper to not use iob_soc fpga wrapper that
  uses mwrap instance
Copy link
Contributor

@jjts jjts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically mem wrappers exist because both simulator and fpga use them. Is there any simulation at all? Does its wrapper repeat the memory instances?

@P-Miranda
Copy link
Contributor Author

The wrapper had the int_mem.v memories from iob-soc
but iob-soc-opencryptolinux does not have int_mem.v, so the memwrapper is redundant

@jjts jjts merged commit 8eeed8d into IObundle:master Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants