-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosimulation feature 1 #233
base: development
Are you sure you want to change the base?
Cosimulation feature 1 #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PandoraQS Thanks for the PR. Please check the comments.
src/main.ts
Outdated
return; | ||
} | ||
|
||
const coeJarPath = path.join(app.getAppPath(), 'resources', 'coe', 'coe.jar'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the application is completely dependent on Maestro, it is probably better to include maestro jar file in resources
during the packaging of the application. Remember to use the latest release.
Please add the an npm command that can execute a small javascript file that can download the latest maestro release and place it in resources. This software can be used for npm start
and npm test
.
In addition, please have the jar integrated into the release being built in npm run dist
step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can push this task to next PR if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The application needs to be responsive. For example, please see this code
…on, moved menu, fixed cosimulation and removed comments
Let us follow the INTO-CPS Project (this is a new project created by a user; similar to the project structure of tutorials) as proposed in this discussion. For this PR, we can work with the following project structure: FMUs
FMU1
FMU2
cosimulation
default/
multi-model.json
experiment.json
results/
experiment_<timestamp>.csv
into-cps.yml Please do update the README to reflect the working project structure expected from the user. |
config.json (one folder above the codebase):
To change the config.coe path in .env:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PandoraQS thanks for the updates. Please check the comments.
src/cosimulation/coeApi.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this convention. The src/cosimulation
is better than src/maestro
. The src/cosimulation/maestro.ts
could still be there for interacting with Maestro at low-level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this file as well.
PR Activities Review:
Added the useCosimulation hook:
Cosimulation component refactored:
Improving the communication via IPC.
TO BE DONE:
|
I have included the diagrams for the Maestro Model and the interaction between Maestro and the UI via IPC. |
TODO: