Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Virtual Env #964

Open
wants to merge 19 commits into
base: feature/distributed-demo
Choose a base branch
from

Conversation

hkirk
Copy link
Contributor

@hkirk hkirk commented Oct 9, 2024

Updates base.sh/env.sh to include Python virtual env for Linux. I updated developer docs accordingly. Solves part of #962

@prasadtalasila
Copy link
Contributor

@hkirk Perhaps the git-hooks text of docs/developer/index.md can be commented out for now.

<!---
git hooks text
-->

docs/developer/index.md Show resolved Hide resolved
docs/developer/index.md Outdated Show resolved Hide resolved
docs/developer/index.md Outdated Show resolved Hide resolved
script/base.sh Show resolved Hide resolved
script/base.sh Show resolved Hide resolved
docs/developer/index.md Show resolved Hide resolved
docs/developer/index.md Show resolved Hide resolved
Copy link

codeclimate bot commented Oct 23, 2024

Code Climate has analyzed commit 094e8b8 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 4
Style 1

View more on Code Climate.

hkirk added 2 commits November 7, 2024 13:31
Create and use virtual env in windows for pip packages
Docker Compose is bundled in docker desktop
NVM is used to update and install node.
@hkirk
Copy link
Contributor Author

hkirk commented Nov 7, 2024

@prasadtalasila here there nvm, docker-compose and venv changes for windows.

Copy link
Contributor

@prasadtalasila prasadtalasila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkirk Thanks for the updates. I've made updates on this PR and pushed them to pr-964 branch. The changes are highlighted in this PR. Please have a look.

@@ -68,14 +67,16 @@ following commands in the given order:
```bash
powershell -F script/base.ps1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These powershell commands seem to work only if executed as follows.

powershell -executionpolicy bypass -F script/base.ps1
powershell -executionpolicy bypass -F script/env.ps1
powershell -executionpolicy bypass -F script/docker.ps1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the because they are not run as administrator?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the problem exists even with administrative privileges

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the check is being made for existence of a certain software (say, choco, git), second execution of base.ps1 throws up errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants