-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Virtual Env #964
base: feature/distributed-demo
Are you sure you want to change the base?
Python Virtual Env #964
Conversation
@hkirk Perhaps the git-hooks text of docs/developer/index.md can be commented out for now. <!---
git hooks text
--> |
…o feature/distributed-demo
Code Climate has analyzed commit 094e8b8 and detected 5 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Create and use virtual env in windows for pip packages
Docker Compose is bundled in docker desktop NVM is used to update and install node.
@prasadtalasila here there nvm, docker-compose and venv changes for windows. |
…o feature/distributed-demo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkirk Thanks for the updates. I've made updates on this PR and pushed them to pr-964 branch. The changes are highlighted in this PR. Please have a look.
@@ -68,14 +67,16 @@ following commands in the given order: | |||
```bash | |||
powershell -F script/base.ps1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These powershell commands seem to work only if executed as follows.
powershell -executionpolicy bypass -F script/base.ps1
powershell -executionpolicy bypass -F script/env.ps1
powershell -executionpolicy bypass -F script/docker.ps1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the because they are not run as administrator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the problem exists even with administrative privileges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the check is being made for existence of a certain software (say, choco
, git
), second execution of base.ps1
throws up errors.
Updates base.sh/env.sh to include Python virtual env for Linux. I updated developer docs accordingly. Solves part of #962