feat(CoreFactory): add create(Class) so as to create elements by reflection #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurieux
reviewed
Nov 10, 2016
| @@ -39,7 +39,9 @@ | |||
| public static Collection<Object[]> data() throws Exception { | |||
| List<Object[]> values = new ArrayList<>(); | |||
| for (Method method : CoreFactory.class.getDeclaredMethods()) { | |||
| if (method.getName().startsWith("create") && method.getReturnType().getSimpleName().startsWith("Ct")) { | |||
| if (method.getName().startsWith("create") | |||
| && method.getParameterCount() == 0 | |||
There was a problem hiding this comment.
why to you change this test?
|
Indeed it is, it is required otherwise the test also considers the new |
|
The PR does not contains test related to the added code. |
|
it does: see SpoonArchitectureEnforcer.java |
|
Your test is not a metamodelPackageRule |
monperrus
force-pushed
the
feat-Factory.create
branch
3 times, most recently
from
f692f8b
to
88fb88e
Compare
monperrus
force-pushed
the
feat-Factory.create
branch
from
88fb88e
to
d6a37c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.