support of comments in snippet #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
requested changes
Nov 5, 2016
| * @param filePath | ||
| * @return a cached compilation unit or null | ||
| */ | ||
| public CompilationUnit remove(String filePath) { |
There was a problem hiding this comment.
rename method to removeFromCache?
There was a problem hiding this comment.
package-visible instead of public?
There was a problem hiding this comment.
removeFromCache
good idea
package-visible
It is different package ... or I do not know this java feature...
|
I have committed the rename of method remove->removeFromCache. I do not know how to implement package visibility if the caller is in different package. I think it is not possible. But Travis does not want to check my last commit. OR am I wrong? |
monperrus
approved these changes
Nov 5, 2016
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments in snippet was always ignored. This PR includes this:
CompilationUnit JDTSnippetCompiler.getSnippetCompilationUnit(), which returns CompilationUnit of the compilet snippet. Note: I had to remember the CompilationUnit of the snippet in the CompilationUnit cache, otherwise JDTCommentBuilder was not able to add comments. And at the end I removed that CU from the cache ... so it is now possible to access that CU from the JDTSnippetCompiler too.It is the first chunk of changes suggested by PR #929