Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comment): Avoid parsing javadoc when it isn't necessary. #676

Merged
merged 1 commit into from
May 26, 2016
Merged

feat(comment): Avoid parsing javadoc when it isn't necessary. #676

merged 1 commit into from
May 26, 2016

Conversation

GerardPaligot
Copy link
Contributor

Fixes for a diabolical issue! 🔥

Closes #666

@monperrus
Copy link
Collaborator

could you update the command line and website documentation as well?

@GerardPaligot
Copy link
Contributor Author

command line

This is the command line of this feature:

// Enable generation of javadoc.
sw1 = new Switch("generate-javadoc");
sw1.setShortFlag('j');
sw1.setLongFlag("generate-javadoc");
sw1.setHelp("Enable the generation of the javadoc.");
sw1.setDefault("false");
jsap.registerParameter(sw1);

We should deprecate this argument and create a new one.

website documentation

Which part?

@GerardPaligot
Copy link
Contributor Author

AppVayor and Travis seems down... but PR updated.

@@ -2,7 +2,7 @@
title: Command Line
tags: [usage]
keywords: command, line, usage, java, jar
last_updated: October 1, 2015
last_updated: May 25, 2015
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016

Fixes for a diabolical issue! 🔥

Closes #666
@GerardPaligot
Copy link
Contributor Author

@monperrus PR ok.

@monperrus monperrus merged commit f2c98cb into INRIA:master May 26, 2016
@GerardPaligot GerardPaligot deleted the feat_666 branch May 26, 2016 09:08
@tdurieux tdurieux mentioned this pull request Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants