New implementation for replace #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. why did you put there the commits related to the output? |
|
I understand. Because you put the result in src/main/java. It really makes sense. Could you separate those commits in a PR that we would accept first? |
|
Which commits? |
|
PR done here #634 |
|
merged, this one can be rebased.
|
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| class ReplacementVisitor extends CtScanner { |
There was a problem hiding this comment.
Adds javadoc.
| import static spoon.generating.replace.ReplaceScanner.GENERATING_REPLACE_VISITOR; | ||
| import static spoon.generating.replace.ReplaceScanner.TARGET_REPLACE_PACKAGE; | ||
|
|
||
| public class GeneratingTypeProcessor extends AbstractProcessor<CtType<?>> { |
There was a problem hiding this comment.
Change to ReplacementVisitorGenerator
| @@ -228,7 +224,7 @@ public boolean equals(Object o) { | |||
| } | |||
|
|
|||
| public List<CtAnnotation<? extends Annotation>> getAnnotations() { | |||
| return Collections.unmodifiableList(annotations); | |||
| return annotations; | |||
There was a problem hiding this comment.
|
@monperrus Should be ok here. |
| launcher.run(); | ||
|
|
||
| assertThat(build(new File("./src/main/java/spoon/support/visitor/replace/ReplacementVisitor.java")).Class().get(ReplacementVisitor.class)) | ||
| .isEqualTo(build(new File("./target/generated/spoon/support/visitor/replace/ReplacementVisitor.java")).Class().get(ReplacementVisitor.class).toString()); |
|
@monperrus Ok here. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #570