feat(shadow): Build shadow element from class object. #569
Conversation
| Assert.assertEquals(2,annot.names().length); | ||
| Assert.assertEquals("foo",annot.names()[0]); | ||
| Assert.assertEquals("bar",annot.names()[1]); | ||
| final CtAnnotation<SampleAnnotation> annotation = type.getAnnotation(type.getFactory().Annotation().createReference(SampleAnnotation.class)); |
There was a problem hiding this comment.
do this change the return type of getAnnotation? is it backward compatible?
There was a problem hiding this comment.
There are two methods named getAnnotation(...):
getAnnotation(Class<Annotation>)which returns anAnnotation.getAnnotation(CtTypeReference)which returns anCtAnnotation<Annotation>.
|
looks nice! we have to find a good name for JScanner and add some API documentation. also, we should add some documentation about this. |
GerardPaligot
changed the title
| * Returns a subtype {@link CtExecutable} that corresponds to the reference | ||
| * even if its declaring type isn't in the Spoon source path. | ||
| * | ||
| * @return the executable declaration correspond to the reference. |
There was a problem hiding this comment.
Typo: correspond -> that corresponds
GerardPaligot
changed the title
| * | ||
| * @return true if the element is a shadow element, otherwise false. | ||
| */ | ||
| boolean isShadow(); |
There was a problem hiding this comment.
Move to CtShadowable
|
new feature: add documentation page |
|
For me:
|
| new CtScanner() { | ||
| @Override | ||
| public void scan(CtElement element) { | ||
| if (element != null && element.getClass().isAssignableFrom(CtShadowable.class)) { |
There was a problem hiding this comment.
should it be
CtShadowable.class.isAssignableFrom(element.getClass())
?
No description provided.