Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REVIEW fix: fix crash with SpoonException in sniper mode #3205

Merged
merged 5 commits into from
Feb 3, 2020

Conversation

woutersmeenk
Copy link
Contributor

@woutersmeenk woutersmeenk commented Jan 16, 2020

@monperrus
Copy link
Collaborator

Thanks a lot for the failing test.

@monperrus
Copy link
Collaborator

Could you allow maintainers to push to your branch? Thanks!

@woutersmeenk
Copy link
Contributor Author

It was already checked:
image

I unchecked it and checked it again. Is it ok now?

@monperrus
Copy link
Collaborator

perfect, it works.

@monperrus monperrus changed the title Add test for https://github.com/INRIA/spoon/issues/3204 fix: fix crash with SpoonException in sniper mode Jan 31, 2020
@monperrus monperrus changed the title fix: fix crash with SpoonException in sniper mode REVIEW fix: fix crash with SpoonException in sniper mode Jan 31, 2020
@monperrus
Copy link
Collaborator

ready to merge

@nharrand
Copy link
Collaborator

nharrand commented Feb 3, 2020

LGTM! Thanks @woutersmeenk (and @monperrus )!

@nharrand nharrand merged commit 91cfbd4 into INRIA:master Feb 3, 2020
moraispgsi added a commit to TQRG/spoon that referenced this pull request Feb 8, 2020
fix: fix crash with SpoonException in sniper mode (INRIA#3205)
MartinWitt pushed a commit to MartinWitt/spoon that referenced this pull request Feb 11, 2020
@monperrus monperrus mentioned this pull request Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot transform class that references inner type when using sniper mode
3 participants