Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Nicolas Harrand becomes integrator #2818

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Conversation

monperrus
Copy link
Collaborator

Dear all,

I'd like to nominate Nicolas Harrand (@nharrand) to become an integrator in Spoon. Nicolas has done several key contributions over the past year:

In addition, Nicolas has proven his ability to communicate constructively and respectfully over issues and pull-requests.

What do you think?

Dear all,

I'd like to nominate Nicolas Harrand (@nharrand) to become an integrator in Spoon. Nicolas has done several key contributions over the past year:

* he has added support for paths in order to uniquely identify AST nodes (#1874), this feature is unique (to my knowledge, it does not exist in any other source code analysis library for Java), and enables original source code analysis over time and versions.
* he has added support for analysis of binary files with decompilation (#2455)
* he has laid down the foundations of a modularized Spoon, which will likely be key in the future
* he has ported Spoon to JDK 11 (#2789). This kind of infrastructure contribution is also very important in the long term.

In addition, Nicolas has proven his ability to communicate constructively and respectfully over issues and pull-requests.

What do you think?
@surli
Copy link
Collaborator

surli commented Dec 4, 2018

+1

@pvojtechovsky
Copy link
Collaborator

Very good idea! I agree 👍

@@ -17,6 +17,7 @@ How to become integrator? The integrators are the developers who have made signi

Current integrators (alphabetical order):

- Nicolas Harrand [@nharrand](https://github.com/nharrand/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just not in alphabetical order ;-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :-)

@monperrus
Copy link
Collaborator Author

6 days, nobody objects, ready for merge?

@pvojtechovsky pvojtechovsky merged commit 3e060c1 into master Dec 10, 2018
@surli surli deleted the monperrus-patch-7 branch December 10, 2018 16:02
@monperrus
Copy link
Collaborator Author

A round of applause for Nicolas @nharrand!
https://github.com/INRIA/spoon/invitations

@surli
Copy link
Collaborator

surli commented Dec 10, 2018

👏

@nharrand
Copy link
Collaborator

Thanks all! I'll try to be worthy 😇.

@pvojtechovsky
Copy link
Collaborator

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants