review: feat: PatternParameterConfigurator substitute by element #2530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add the tests? Thanks. |
pvojtechovsky
force-pushed
the
feaParamCfgByElement
branch
from
cafe3ab
to
31b813f
Compare
pvojtechovsky
changed the title
|
I WiP it because it needs merge of #2555 first. |
pvojtechovsky
force-pushed
the
feaParamCfgByElement
branch
from
31b813f
to
faa40ac
Compare
pvojtechovsky
changed the title
|
I am finished here. It is ready for merge |
|
the way to go @danglotb ! |
|
thanks Pavel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends API of PatternParameterConfigurator, by way individual CtElements may be substituted by pattern parameter. It is similar like
PatternParameterConfigurator#byFilter, just elements are explicitly listed.It is needed by
PatternDetectorfeature ... coming soon.