Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix SonarQube - change 'String' to 'char' in string functions #2436

Merged
merged 1 commit into from
Sep 2, 2018
Merged

refactor: fix SonarQube - change 'String' to 'char' in string functions #2436

merged 1 commit into from
Sep 2, 2018

Conversation

zielint0
Copy link
Contributor

@zielint0 zielint0 commented Sep 1, 2018

SonarQube checker: An indexOf or lastIndexOf call with a single letter String can be made more performant by switching to a call with a char argument.

Copy link
Collaborator

@pvojtechovsky pvojtechovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomasz!

@pvojtechovsky pvojtechovsky merged commit 9dcd554 into INRIA:master Sep 2, 2018
@zielint0 zielint0 deleted the refactor-fix-sonarqube-String-function-use-should-be-optimized-for-single-characters branch September 4, 2018 17:57
@monperrus monperrus mentioned this pull request Sep 20, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants