refactor: simplify assertions in AnnotationTest.java #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
reviewed
Aug 31, 2018
| @@ -299,7 +299,7 @@ public void testAnnotatedElementTypes() { | |||
| // check annotated element type of the package annotation | |||
| List<CtAnnotation<?>> annotations = pkg.getAnnotations(); | |||
| assertEquals(2, annotations.size()); | |||
| assertTrue(annotations.get(0).getAnnotatedElement().equals(pkg)); | |||
| assertEquals(annotations.get(0).getAnnotatedElement(), pkg); | |||
There was a problem hiding this comment.
the expected value should be first.
There was a problem hiding this comment.
@monperrus
Thanks! I fixed this one.
Could you check other tests I modified?
|
@zielint0 All the AssertEquals of this PR (excluding the one you already fixed) needs to switch parameters: the expected value should be first. |
pvojtechovsky
changed the title
zielint0
changed the title
|
@pvojtechovsky |
zielint0
deleted the
refactor-simplify-assertions-AnnotationTest.java
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use straightforward assertion - assertEquals for testing equality.
-->